From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Jonathan Nieder <jrnieder@gmail.com>, Yuri <yuri@rawbw.com>
Subject: [PATCH 0/3] improved out-of-the-box color settings
Date: Thu, 16 Jan 2014 23:14:30 -0500 [thread overview]
Message-ID: <20140117041430.GB19551@sigill.intra.peff.net> (raw)
In-Reply-To: <20140117023548.GB13023@sigill.intra.peff.net>
On Thu, Jan 16, 2014 at 09:35:48PM -0500, Jeff King wrote:
> I can prepare a patch series, but I happily no longer have any antique
> systems to test this kind of stuff on.
Here it is. For those just joining us, the problem is that on some
systems, "git log" out of the box produces ANSI codes which are munged
by the pager and look terrible. I'm trying to improve that by
auto-configuring "more" (to get color in more cases that can handle it),
and by dynamically adjusting color.pager's default based on which pager
is in use (to turn off color in cases we know won't work).
I was able to test my assumptions about "MORE" on Debian, and adjusted
the patches accordingly from the previous discussion. I am still
guessing that versions of "more" without "R" will pass through the ANSI
codes as-is. That works on Debian. If anybody has an older system to
test and report on, I'd love to hear it.
The second patch turns on "MORE=R" only for FreeBSD. Yuri, if you can
confirm that my patch works for you, that would be excellent. And if you
(or anyone) has access to NetBSD or OpenBSD to test the second patch on,
I'd welcome updates to config.mak.uname for those systems.
We also set "LV=-c" along with "LESS". I punted on detecting that in the
third patch, as I do not know the exact format of "LV". It looks like
just checking for "c" might not be enough, and I need to actually
understand the option format (i.e., "-c" or "-dc", but not "-Ac"). I'll
leave that to somebody who cares more about LV to improve (with these
patches, the behavior for them should remain the same, so it's at least
not making anything worse).
[1/3]: setup_pager: refactor LESS/LV environment setting
[2/3]: setup_pager: set MORE=R
[3/3]: pager: disable colors for some known-bad configurations
-Peff
next prev parent reply other threads:[~2014-01-17 4:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 0:34 'git log' escape symbols shown as ESC[33 and ESC[m Yuri
2014-01-17 1:47 ` Jeff King
2014-01-17 2:02 ` Yuri
2014-01-17 2:13 ` Jeff King
2014-01-17 2:28 ` Yuri
2014-01-17 2:32 ` Jeff King
2014-01-17 2:46 ` Yuri
2014-01-17 2:29 ` Jonathan Nieder
2014-01-17 2:35 ` Jeff King
2014-01-17 3:21 ` Jeff King
2014-01-17 4:14 ` Jeff King [this message]
2014-01-17 4:21 ` [PATCH 1/3] setup_pager: refactor LESS/LV environment setting Jeff King
2014-01-17 4:21 ` [PATCH 2/3] setup_pager: set MORE=R Jeff King
2014-01-17 7:26 ` Kyle J. McKay
2014-01-17 19:11 ` Junio C Hamano
2014-01-21 5:30 ` Jeff King
2014-01-21 8:42 ` Kyle J. McKay
2014-01-23 2:14 ` Jeff King
2014-01-23 17:22 ` Junio C Hamano
2014-01-17 19:17 ` Junio C Hamano
2014-01-17 19:57 ` Junio C Hamano
2014-01-17 23:42 ` Junio C Hamano
2014-01-21 6:13 ` Jeff King
2014-01-21 19:28 ` Junio C Hamano
2014-01-21 5:49 ` Jeff King
2014-01-21 19:23 ` Junio C Hamano
2014-02-04 22:12 ` Jeff King
2014-02-04 22:17 ` Junio C Hamano
2014-02-04 22:25 ` Jeff King
2014-02-04 22:45 ` Yuri
2014-02-04 22:48 ` Jeff King
2014-02-04 22:54 ` Junio C Hamano
2014-02-04 23:00 ` Yuri
2014-02-05 2:11 ` Kyle J. McKay
2014-01-17 4:24 ` [PATCH 3/3] pager: disable colors for some known-bad configurations Jeff King
2014-01-17 9:13 ` [PATCH 0/3] improved out-of-the-box color settings Yuri
2014-01-17 20:15 ` 'git log' escape symbols shown as ESC[33 and ESC[m Yuri
2014-02-05 1:24 ` Yuri
2014-02-05 1:33 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117041430.GB19551@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=yuri@rawbw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).