From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, Eric Wong <e@80x24.org>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK
Date: Mon, 27 Jun 2016 15:51:38 -0400 [thread overview]
Message-ID: <20160627195138.GA15147@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kZWfGJG=qHtdpuLvQY5XK5P3L0UW7RJ=9ui=PgX+AjErQ@mail.gmail.com>
On Mon, Jun 27, 2016 at 12:43:32PM -0700, Stefan Beller wrote:
> There are a few issues:
>
> 1) How did you spot the bug? ("Experience/Logical thinking" is the hand
> wavy answer, but if you had a list like
> [ ] check for mem leak
> [ ] check for futureproof design
> [ ] check for failure modes (What if a syscall fails?")
> [ ] ... List is not complete, but has some made up points
I use the hand-wavy approach to reviews, and I'm pretty sure that's how
I saw your bug (just thinking about what the code would do, how I would
write it, and then noticing a discrepancy).
I suspect a checklist could make things more thorough, but I think it
can also discourage deep thinking. Ideally we have some reviewers who
are checklist-oriented looking for those sorts of details and some who
are not.
> 2) I used to send out only "done"s, i.e. when I already fixed the
> issue, instead of acknowledging the problem and postponing the fix
> for later. I'll revert to that.
Yes, I tend to use the review thread as a todo list, and do a single
session where I read over all of the review mails again (even if I've
read and responded to them already), fixing or adjusting the code. Sort
of a human version of the automated tool I described. :)
> > Of course, none of that would have helped my comment, which was in a
> > "PS" several emails deep in a discussion thread. ;)
>
> Maybe a "P.S." would get its own point in the todo list not associated
> with code? Then it would still be on the radar.
Yes, there are definitely design points that are not about a specific
part of the code, and you would want to somehow represent them in your
todo list.
There is a danger, though, of having a bunch of false positives added to
your list: tangent discussion that distracts you from the actual review.
And I think the bug here being in a PS is less relevant than being
buried amidst other discussion. That made it hard for a tool _or_ a
human to find.
-Peff
next prev parent reply other threads:[~2016-06-27 19:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 23:21 [PATCH 0/2] wrapper: xread/xwrite fixes for non-blocking FDs Eric Wong
2016-06-26 23:21 ` [PATCH 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK Eric Wong
2016-06-26 23:42 ` Jeff King
2016-06-27 13:02 ` Junio C Hamano
2016-06-27 14:36 ` Jeff King
2016-06-27 16:49 ` Stefan Beller
2016-06-27 19:17 ` Jeff King
2016-06-27 19:43 ` Stefan Beller
2016-06-27 19:51 ` Jeff King [this message]
2016-06-27 20:13 ` Eric Wong
2016-06-27 21:49 ` Jeff King
2016-06-27 22:22 ` Jeff King
2016-06-27 23:19 ` Eric Wong
2016-06-26 23:51 ` Jeff King
2016-06-27 3:56 ` [PATCHv2 " Eric Wong
2016-06-26 23:21 ` [PATCH 2/2] xwrite: poll on non-blocking FDs Eric Wong
2016-06-26 23:49 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627195138.GA15147@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).