From: Jeff King <peff@peff.net>
To: Eric Wong <e@80x24.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Stefan Beller <sbeller@google.com>,
git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK
Date: Sun, 26 Jun 2016 19:51:29 -0400 [thread overview]
Message-ID: <20160626235129.GC21668@sigill.intra.peff.net> (raw)
In-Reply-To: <20160626232112.721-2-e@80x24.org>
On Sun, Jun 26, 2016 at 11:21:11PM +0000, Eric Wong wrote:
> We should continue to loop after EAGAIN/EWOULDBLOCK as the
> intent of xread is to read as much as possible until an
> EOF or real error occurs.
BTW, a minor nit here. xread() does _not_ read as much as possible until
EOF. It tries until it gets a real error or at least one byte.
I know you inherited this mistaken text from 1079c4be0b, but we should
probably not repeat it.
-Peff
next prev parent reply other threads:[~2016-06-26 23:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 23:21 [PATCH 0/2] wrapper: xread/xwrite fixes for non-blocking FDs Eric Wong
2016-06-26 23:21 ` [PATCH 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK Eric Wong
2016-06-26 23:42 ` Jeff King
2016-06-27 13:02 ` Junio C Hamano
2016-06-27 14:36 ` Jeff King
2016-06-27 16:49 ` Stefan Beller
2016-06-27 19:17 ` Jeff King
2016-06-27 19:43 ` Stefan Beller
2016-06-27 19:51 ` Jeff King
2016-06-27 20:13 ` Eric Wong
2016-06-27 21:49 ` Jeff King
2016-06-27 22:22 ` Jeff King
2016-06-27 23:19 ` Eric Wong
2016-06-26 23:51 ` Jeff King [this message]
2016-06-27 3:56 ` [PATCHv2 " Eric Wong
2016-06-26 23:21 ` [PATCH 2/2] xwrite: poll on non-blocking FDs Eric Wong
2016-06-26 23:49 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160626235129.GC21668@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).