From: Jeff King <peff@peff.net>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Duy Nguyen <pclouds@gmail.com>,
git-for-windows <git-for-windows@googlegroups.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH jk/push-client-deadlock-fix] Windows: add pthread_sigmask() that does nothing
Date: Tue, 3 May 2016 00:48:46 -0400 [thread overview]
Message-ID: <20160503044845.GC32259@sigill.intra.peff.net> (raw)
In-Reply-To: <57265425.9050205@kdbg.org>
On Sun, May 01, 2016 at 09:08:21PM +0200, Johannes Sixt wrote:
> A previous change introduced a call to pthread_sigmask() in order to block
> SIGPIPE in a thread. Since there are no signal facilities on Windows that
> are similar to POSIX signals, just ignore the request to block the signal.
> In the particular case, the effect of blocking SIGPIPE on POSIX is that
> write() calls return EPIPE when the reader closes the pipe. This is how
> write() behaves on Windows.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
Looks good to me based on our earlier discussion (but of course I have
no platform to test it on).
-Peff
prev parent reply other threads:[~2016-05-03 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 11:06 pthread_sigmask() on windows (wine actualy) Duy Nguyen
2016-05-01 17:45 ` Jeff King
2016-05-01 19:08 ` [PATCH jk/push-client-deadlock-fix] Windows: add pthread_sigmask() that does nothing Johannes Sixt
2016-05-03 4:48 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503044845.GC32259@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git-for-windows@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).