From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
git-for-windows <git-for-windows@googlegroups.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: pthread_sigmask() on windows (wine actualy)
Date: Sun, 1 May 2016 13:45:36 -0400 [thread overview]
Message-ID: <20160501174535.GB17321@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8BrKsasiXZcc3=mm9Pq=qz_h6pi8edzpmT_7mKxwjnAqQ@mail.gmail.com>
On Sun, May 01, 2016 at 06:06:07PM +0700, Duy Nguyen wrote:
> I got this while compiling master today using mingw32 cross toolchain
>
> CC run-command.o
> run-command.c: In function 'run_thread':
> run-command.c:596:3: warning: implicit declaration of function
> 'pthread_sigmask' [-Wimplicit-function-declaration]
> run-command.c:596:23: error: 'SIG_BLOCK' undeclared (first use in this function)
> run-command.c:596:23: note: each undeclared identifier is reported
> only once for each function it appears in
>
> This is added in c792d7b (run-command: teach async threads to ignore
> SIGPIPE - 2016-04-19). From the look of it, wrapping #ifndef
> GIT_WINDOWS_NATIVE is probably enough? I checked gfw/master too to see
> how gfw deals with it, but the commit has not been merged there yet.
I think the fix should go into compat/. See
http://git.661346.n2.nabble.com/PATCH-0-5-fix-deadlock-in-git-push-tp7653666p7653818.html
(sorry, gmane seems down).
-Peff
next prev parent reply other threads:[~2016-05-01 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 11:06 pthread_sigmask() on windows (wine actualy) Duy Nguyen
2016-05-01 17:45 ` Jeff King [this message]
2016-05-01 19:08 ` [PATCH jk/push-client-deadlock-fix] Windows: add pthread_sigmask() that does nothing Johannes Sixt
2016-05-03 4:48 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160501174535.GB17321@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git-for-windows@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).