From: Jeff King <peff@peff.net>
To: "Tom G. Christensen" <tgc@jupiterrise.com>
Cc: Patrick Steinhardt <ps@pks.im>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: git segfaults on older Solaris releases
Date: Sat, 9 Apr 2016 16:35:31 -0400 [thread overview]
Message-ID: <20160409203530.GA18989@sigill.intra.peff.net> (raw)
In-Reply-To: <57096374.6030608@jupiterrise.com>
On Sat, Apr 09, 2016 at 10:17:56PM +0200, Tom G. Christensen wrote:
> On 09/04/16 19:39, Jeff King wrote:
>
> > [1/3]: config: lower-case first word of error strings
> > [2/3]: git_config_set_multivar_in_file: all non-zero returns are errors
> > [3/3]: git_config_set_multivar_in_file: handle "unset" errors
> >
>
> I applied them to 2.8.1 and ran the testsuite again on Solaris 8/x86 and the
> segfault is gone.
Thanks for testing. By the way, I ran the whole test suite with "--tee -v"
and grepped for "(null)", which does find this case on glibc systems. I
didn't see any other interesting cases (there _are_ mentions of
"(null)", but they are from our code, not glibc converting NULLs). Which
I guess is just corroborating your testing, since you would have seen
any bad cases as segfaults.
-Peff
next prev parent reply other threads:[~2016-04-09 20:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 18:18 git segfaults on older Solaris releases Tom G. Christensen
2016-04-07 18:32 ` Junio C Hamano
2016-04-07 18:50 ` Junio C Hamano
2016-04-07 18:56 ` David Turner
2016-04-07 19:07 ` Jeff King
2016-04-07 19:37 ` Junio C Hamano
2016-04-07 20:24 ` Jeff King
2016-04-07 20:19 ` Tom G. Christensen
2016-04-09 7:02 ` Tom G. Christensen
2016-04-09 17:39 ` Jeff King
2016-04-09 17:42 ` [PATCH 1/3] config: lower-case first word of error strings Jeff King
2016-04-09 17:42 ` [PATCH 2/3] git_config_set_multivar_in_file: all non-zero returns are errors Jeff King
2016-04-09 17:43 ` [PATCH 3/3] git_config_set_multivar_in_file: handle "unset" errors Jeff King
2016-04-09 20:17 ` git segfaults on older Solaris releases Tom G. Christensen
2016-04-09 20:35 ` Jeff King [this message]
2016-04-12 10:21 ` Patrick Steinhardt
2016-04-07 18:58 ` Tom G. Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160409203530.GA18989@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
--cc=tgc@jupiterrise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).