From: Jeff King <peff@peff.net>
To: "Tom G. Christensen" <tgc@jupiterrise.com>
Cc: Patrick Steinhardt <ps@pks.im>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: git segfaults on older Solaris releases
Date: Sat, 9 Apr 2016 13:39:05 -0400 [thread overview]
Message-ID: <20160409173904.GA5127@sigill.intra.peff.net> (raw)
In-Reply-To: <5708A90E.1050705@jupiterrise.com>
On Sat, Apr 09, 2016 at 09:02:38AM +0200, Tom G. Christensen wrote:
> I've finished testing 2.8.1 and I found one more case where a null is being
> printed and causing a segfault. This happens even on Solaris 8 and 9.
> The failling test is t3200.63.
Oh good, this one wasn't me. :)
It's just a normal "oops, we feed NULL and nobody on glibc noticed
because it silently replaced it with "(null)" case. I did find a few
other oddities while fixing it, though. +cc Patrick, who worked in this
area most recently.
[1/3]: config: lower-case first word of error strings
[2/3]: git_config_set_multivar_in_file: all non-zero returns are errors
[3/3]: git_config_set_multivar_in_file: handle "unset" errors
I think we may want some additional improvements. While doing 1/3, I
noticed that many of these error messages could stand to be marked for
translation. As other people are already looking at mass-conversion,
I stopped short of doing it here (and merely contented myself with
throwing a conflict into their patches ;) ).
The other thing is that 2/3 notices the error return from the
config-setting functions is weird. It's sometimes negative and sometimes
positive. I fixed this caller, but I think it's possible for the
negative values to leak into our exit codes:
$ touch .git/config
$ git config foo.bar baz
error: could not lock config file .git/config: File exists
$ echo $?
255
I seem to recall some systems having trouble with negative error codes,
so we may want to make that more consistent.
-Peff
next prev parent reply other threads:[~2016-04-09 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 18:18 git segfaults on older Solaris releases Tom G. Christensen
2016-04-07 18:32 ` Junio C Hamano
2016-04-07 18:50 ` Junio C Hamano
2016-04-07 18:56 ` David Turner
2016-04-07 19:07 ` Jeff King
2016-04-07 19:37 ` Junio C Hamano
2016-04-07 20:24 ` Jeff King
2016-04-07 20:19 ` Tom G. Christensen
2016-04-09 7:02 ` Tom G. Christensen
2016-04-09 17:39 ` Jeff King [this message]
2016-04-09 17:42 ` [PATCH 1/3] config: lower-case first word of error strings Jeff King
2016-04-09 17:42 ` [PATCH 2/3] git_config_set_multivar_in_file: all non-zero returns are errors Jeff King
2016-04-09 17:43 ` [PATCH 3/3] git_config_set_multivar_in_file: handle "unset" errors Jeff King
2016-04-09 20:17 ` git segfaults on older Solaris releases Tom G. Christensen
2016-04-09 20:35 ` Jeff King
2016-04-12 10:21 ` Patrick Steinhardt
2016-04-07 18:58 ` Tom G. Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160409173904.GA5127@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
--cc=tgc@jupiterrise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).