From: Jeff King <peff@peff.net>
To: "Carlos Martín Nieto" <cmn@dwim.me>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH] gpg: add support for gpgsm
Date: Thu, 31 Mar 2016 13:30:25 -0400 [thread overview]
Message-ID: <20160331173025.GA1809@sigill.intra.peff.net> (raw)
In-Reply-To: <1459440486.2124.18.camel@dwim.me>
On Thu, Mar 31, 2016 at 06:08:06PM +0200, Carlos Martín Nieto wrote:
> > I notice that you had to add GPGSM_MESSAGE string constant; does the
> > current code without any change really work correctly if you set
> > 'gpg.program' to gpgsm and do nothing else?
>
> It does work for verify-commit which is what I've been playing around
> with since it just sends the contents of the 'gpgsig' header field to
> the verification function.
>
> I don't recall testing with verify-tag but there we might indeed have
> issues, since we parse the contents to see if we have the signature.
Ah, right, I think I had it backwards in my earlier posting. The
"gpgsig" headers are what trigger us for signed commits, not the "BEGIN
PGP" line, and verify-tag does indeed parse the signature out.
I think we'd also fail to pick up signatures from merges of signed tags.
-Peff
prev parent reply other threads:[~2016-03-31 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:51 [RFC PATCH] gpg: add support for gpgsm Carlos Martín Nieto
2016-03-31 14:22 ` Jeff King
2016-03-31 14:44 ` Carlos Martín Nieto
2016-03-31 15:49 ` Junio C Hamano
2016-03-31 15:46 ` Junio C Hamano
2016-03-31 15:57 ` Jeff King
2016-03-31 16:08 ` Carlos Martín Nieto
2016-03-31 17:30 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331173025.GA1809@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=cmn@dwim.me \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).