git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Carlos Martín Nieto" <cmn@dwim.me>, git@vger.kernel.org
Subject: Re: [RFC PATCH] gpg: add support for gpgsm
Date: Thu, 31 Mar 2016 11:57:53 -0400	[thread overview]
Message-ID: <20160331155753.GA1006@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqa8ler6pu.fsf@gitster.mtv.corp.google.com>

On Thu, Mar 31, 2016 at 08:46:05AM -0700, Junio C Hamano wrote:

> Carlos Martín Nieto <cmn@dwim.me> writes:
> 
> > Detect the gpgsm block header and run this command instead of gpg.
> > On the signing side, ask gpgsm if it knows the signing key we're trying
> > to use and fall back to gpg if it does not.
> >
> > This lets the user more easily combine signing and verifying X509 and
> > PGP signatures without having to choose a default for a particular
> > repository that may need to be occasionally overridden.
> >
> > Signed-off-by: Carlos Martín Nieto <cmn@dwim.me>
> >
> > ---
> >
> > Out there in the so-called "real world", companies like using X509 to
> > sign things. Currently you can set 'gpg.program' to gpgsm to get
> > gpg-compatible verification,...
> 
> I notice that you had to add GPGSM_MESSAGE string constant; does the
> current code without any change really work correctly if you set
> 'gpg.program' to gpgsm and do nothing else?

It has been a few months since I fooled around with gpgsm, but IIRC, it
works for tags but not commits. Because verify-tag just blindly dumps
the tag to gpg.program, and gpgsm finds the correct signature. Whereas
the --show-signature option of git-log does not bother to call gpg if we
didn't see a signature.

Which makes me wonder whether verify-tag would send a gpgsm-signed tag
to the right place with Carlos's patch (I didn't check).

-Peff

  reply	other threads:[~2016-03-31 15:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 13:51 [RFC PATCH] gpg: add support for gpgsm Carlos Martín Nieto
2016-03-31 14:22 ` Jeff King
2016-03-31 14:44   ` Carlos Martín Nieto
2016-03-31 15:49   ` Junio C Hamano
2016-03-31 15:46 ` Junio C Hamano
2016-03-31 15:57   ` Jeff King [this message]
2016-03-31 16:08   ` Carlos Martín Nieto
2016-03-31 17:30     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331155753.GA1006@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=cmn@dwim.me \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).