git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Sebastian Schuberth <sschuberth@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v1] config: add '--sources' option to print the source of a config value
Date: Mon, 8 Feb 2016 07:11:09 -0500	[thread overview]
Message-ID: <20160208121108.GB24217@sigill.intra.peff.net> (raw)
In-Reply-To: <DF57DD4F-630F-421D-A379-0A451F6509DF@gmail.com>

On Sun, Feb 07, 2016 at 08:28:26PM +0100, Lars Schneider wrote:

> > I think he inherited the "--sources" name from me. :) I agree it could
> > be better. I think "--show-filename" is not right as there are
> > non-filename cases.  Just "--origin" sounds funny to me, perhaps because
> > of git's normal use of the word "origin".
> > 
> > I like "--show-origin" the best of the ones suggested.
> 
> I understand your reasoning and I agree that "--show-origin" is better than
> "--sources". However, I think just the word "origin" could be misleading in 
> this context because people associate it with Git remotes. How about
> "--show-config-origin" then? Or would that be too verbose?

I think "-config" is redundant here, as we are running "git config". We
have "--add" and not "--add-config", after all.

I dunno. TBH, I do not find --sources to be all that bad. I suspect we
could nitpick any name, and at least it is short and unique.

-Peff

  parent reply	other threads:[~2016-02-08 12:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05  8:42 [PATCH v1] config: add '--sources' option to print the source of a config value larsxschneider
2016-02-05 11:13 ` Sebastian Schuberth
2016-02-05 11:22   ` Jeff King
2016-02-07 19:28     ` Lars Schneider
2016-02-08 11:22       ` Sebastian Schuberth
2016-02-08 12:11       ` Jeff King [this message]
2016-02-05 11:20 ` Jeff King
2016-02-05 11:31   ` Sebastian Schuberth
2016-02-05 13:58     ` Jeff King
2016-02-07 19:44       ` Lars Schneider
2016-02-08 12:12         ` Jeff King
2016-02-08 11:25       ` Sebastian Schuberth
2016-02-08 12:08         ` Jeff King
2016-02-07 18:26   ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160208121108.GB24217@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=sschuberth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).