git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: larsxschneider@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v1] config: add '--sources' option to print the source of a config value
Date: Mon, 8 Feb 2016 07:08:39 -0500	[thread overview]
Message-ID: <20160208120838.GA24217@sigill.intra.peff.net> (raw)
In-Reply-To: <56B87B46.6050304@gmail.com>

On Mon, Feb 08, 2016 at 12:25:58PM +0100, Sebastian Schuberth wrote:

> On 2/5/2016 14:58, Jeff King wrote:
> 
> >Yeah, I agree it's unlikely. And the output is already ambiguous, as the
> >first field could be a blob (though I guess the caller knows if they
> >passed "--blob" or not). If we really wanted an unambiguous output, we
> >could have something like "file:...", "blob:...", etc. But that's a bit
> >less readable for humans, and I don't think solves any real-world
> >problems.
> >
> >So I think it would be OK to use "<command line>" here, as long as the
> >token is documented.
> 
> Thinking about it again, I actually do like Peff's prefix solution better.
> It would solve the real-world problem that my proposed "<command line>"
> marker could in fact be a file name.

I'm OK with that direction, but I think it will need some more
infrastructure in the config code (right now we just set "name" to some
string without recording its type). It probably would not be too hard to
add, though.

-Peff

  reply	other threads:[~2016-02-08 12:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05  8:42 [PATCH v1] config: add '--sources' option to print the source of a config value larsxschneider
2016-02-05 11:13 ` Sebastian Schuberth
2016-02-05 11:22   ` Jeff King
2016-02-07 19:28     ` Lars Schneider
2016-02-08 11:22       ` Sebastian Schuberth
2016-02-08 12:11       ` Jeff King
2016-02-05 11:20 ` Jeff King
2016-02-05 11:31   ` Sebastian Schuberth
2016-02-05 13:58     ` Jeff King
2016-02-07 19:44       ` Lars Schneider
2016-02-08 12:12         ` Jeff King
2016-02-08 11:25       ` Sebastian Schuberth
2016-02-08 12:08         ` Jeff King [this message]
2016-02-07 18:26   ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160208120838.GA24217@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=sschuberth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).