From: Jeff King <peff@peff.net>
To: arnaud brejeon <arnaud.brejeon@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
matthijs@stdin.nl, Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 1/2] Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt
Date: Fri, 25 Oct 2013 03:24:29 -0400 [thread overview]
Message-ID: <20131025072429.GB17029@sigill.intra.peff.net> (raw)
In-Reply-To: <005DF7EA-CF5A-408F-A145-07F53D836974@gmail.com>
On Mon, Oct 21, 2013 at 07:06:29PM +0200, arnaud brejeon wrote:
> I dont know if you plan to keep GIT_ASKPASS as is, but this
> environment variable is not mentioned on git svn documentation and I
> guess just a few people know about it. Moreover, the name is
> misleading as it handles all the prompts, not only the password one.
Yes, the "askpass" name is a little odd, but it is historical. The
calling convention was invented for ssh, who used that name (and we do
respect SSH_ASKPASS if it is set). Besides being a lousy name for
requesting non-password data, it's also a lousy program for doing it.
There's no way for the caller to specify "this is not a password", so
the program always hides the characters as they are typed. It's one of
the reasons the "git credential" subsystem was invented, which has a
more flexible interface.
The askpass variables are documented in "git help credentials". However,
the rest of that document does not apply to git-svn, which is unlike the
rest of git in the way it handles authentication. So it might or might
not make sense to point to it from the git-svn docs. Patches welcome if
you want to look into it.
-Peff
prev parent reply other threads:[~2013-10-25 7:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 9:23 [PATCH 1/2] Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt arnaud.brejeon
2013-10-12 9:23 ` [PATCH 2/2] Add SVN trust-server-cert parameter to git svn to accept SSL server certificates from unknwon authorities without prompting arnaud.brejeon
2013-10-14 14:11 ` [PATCH 1/2] Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt Jonathan Nieder
2013-10-14 18:40 ` Eric Wong
2013-10-14 22:36 ` Jeff King
2013-10-14 23:35 ` Eric Wong
2013-10-15 17:07 ` arnaud brejeon
2013-10-21 17:06 ` arnaud brejeon
2013-10-25 7:24 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025072429.GB17029@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=arnaud.brejeon@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=matthijs@stdin.nl \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).