From: Eric Wong <normalperson@yhbt.net>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
arnaud.brejeon@gmail.com, git@vger.kernel.org, matthijs@stdin.nl
Subject: Re: [PATCH 1/2] Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt
Date: Mon, 14 Oct 2013 23:35:56 +0000 [thread overview]
Message-ID: <20131014233556.GA31230@dcvr.yhbt.net> (raw)
In-Reply-To: <20131014223602.GB12116@sigill.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> On Mon, Oct 14, 2013 at 06:40:05PM +0000, Eric Wong wrote:
>
> > > arnaud.brejeon@gmail.com wrote:
> > >
> > > > Signed-off-by: Arnaud Brejeon <arnaud.brejeon <at> gmail.com>
> > >
> > > Thanks.
> > >
> > > Can you say a little more about the context? Do you run a script that
> > > wants to pass a password to 'git svn', do you type it each time on the
> > > command line, or something else? Is it ok that the password would
> > > show up in "ps" output? Would the platform's keyring or netrc be
> > > usable here, or is there something in the context that avoids that?
> >
> > I think using keyring or netrc is more appropriate. Having a password
> > on the command-line and visible to all via ps doesn't seem like
> > something git should support.
>
> Agreed. We have ready-made git-credential helpers to handle this exact
> problem. We would need to convert SVN::Prompt to use git-credential
> rather than prompting itself, though. One of the things that held me
> back from writing such a patch is that I thought libsvn already handled
> things like keychain integration, and it was better for git-svn to be
> more svn-like than git-like in its access of SVN repos.
>
> Are those already supported out of the box by libsvn? If git's
> credential helpers are significantly more featureful, it might be worth
> converting, but if not, I think it makes sense to stay with svn's
> existing code.
I looks like this patch was forgotten once again:
http://mid.gmane.org/1371573490-21973-1-git-send-email-matthijs@stdin.nl
Matthijs: can you add a Signed-off-by for your patch? I'm inclined to
push it to Junio as-is since it looks reasonable.
I admit I don't know SVN callbacks anymore well enough and don't have
time to test with GNOME.
next prev parent reply other threads:[~2013-10-14 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 9:23 [PATCH 1/2] Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt arnaud.brejeon
2013-10-12 9:23 ` [PATCH 2/2] Add SVN trust-server-cert parameter to git svn to accept SSL server certificates from unknwon authorities without prompting arnaud.brejeon
2013-10-14 14:11 ` [PATCH 1/2] Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt Jonathan Nieder
2013-10-14 18:40 ` Eric Wong
2013-10-14 22:36 ` Jeff King
2013-10-14 23:35 ` Eric Wong [this message]
2013-10-15 17:07 ` arnaud brejeon
2013-10-21 17:06 ` arnaud brejeon
2013-10-25 7:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014233556.GA31230@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=arnaud.brejeon@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=matthijs@stdin.nl \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).