From: Jeff King <peff@peff.net>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [REQUEST 1/1] docs: update http.<url>.* options documentation
Date: Fri, 26 Jul 2013 22:43:53 -0400 [thread overview]
Message-ID: <20130727024353.GA19853@sigill.intra.peff.net> (raw)
In-Reply-To: <251106F7-56FA-4503-A4C9-267A5EF04A2C@gmail.com>
On Fri, Jul 26, 2013 at 07:15:07PM -0700, Kyle J. McKay wrote:
> So there's a version of this in next as cea9928 and I think that
> version is fine. If the documentation gets updated in the future, or
> perhaps moved to a separate urls-matching.txt for some reason at some
> point (git config --url, git config --url-parse), I'll make a point
> of inserting the ", but at lower precedence than a config key with a
> user name" text.
Unless you are planning to do that immediately, we are very likely to
forget. Either it is worth adding or not, and if it is, we should not
let having to add one more commit stop us.
Here it is in patch form, so the amount of effort does not influence our
decision. :)
I'd lean towards including it, but don't feel strongly.
-- >8 --
Subject: [PATCH] docs: mention precedence of empty username matching in URLs
The documentation makes it clear that a URL with a username
will match a config entry with or without a username, but is
not clear that in the presence of both, the one with
username would be preferred.
Signed-off-by: Jeff King <peff@peff.net>
---
Documentation/config.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 0dd5566..f2ed9ef 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -1568,7 +1568,8 @@ http.<url>.*::
. User name (e.g., `user` in `https://user@example.com/repo.git`). If
the config key has a user name it must match the user name in the
URL exactly. If the config key does not have a user name, that
- config key will match a URL with any user name (including none).
+ config key will match a URL with any user name (including none),
+ but at a lower precedence than a config key with a user name.
--
+
The list above is ordered by decreasing precedence; a URL that matches
--
1.8.3.rc1.30.gff0fb75
next prev parent reply other threads:[~2013-07-27 2:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 22:39 [REQUEST 0/1] Requesting your signed-off-by Kyle J. McKay
2013-07-25 22:39 ` [REQUEST 1/1] docs: update http.<url>.* options documentation Kyle J. McKay
2013-07-26 4:37 ` Jeff King
2013-07-26 5:53 ` Junio C Hamano
2013-07-26 6:07 ` Junio C Hamano
2013-07-26 6:23 ` Kyle J. McKay
2013-07-26 22:27 ` Jeff King
2013-07-27 2:15 ` Kyle J. McKay
2013-07-27 2:43 ` Jeff King [this message]
2013-07-27 3:04 ` Kyle J. McKay
2013-07-26 6:42 ` Kyle J. McKay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130727024353.GA19853@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).