From: Jeff King <peff@peff.net>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [REQUEST 1/1] docs: update http.<url>.* options documentation
Date: Fri, 26 Jul 2013 18:27:32 -0400 [thread overview]
Message-ID: <20130726222732.GA3444@sigill.intra.peff.net> (raw)
In-Reply-To: <0A68F4A5-22B0-4629-8693-73258566E218@gmail.com>
On Thu, Jul 25, 2013 at 11:23:23PM -0700, Kyle J. McKay wrote:
> >IMHO, this would be more clear as a single item, like:
> >
> > . User name (e.g., `user` in `https://user@example.com/repo.git`). If
> > the config key has a user name it must match the user name in the
> > URL exactly. If the config key does not have a user name, that
> > config key will match a URL with any user name (including none).
>
> The only problem I have with a single item is what's the precedence?
> Does an exact user match have the same precedence as an any-user
> match? That would seem to be implied by having them as the same item
> number. Separating them would appear to make it clearer that an
> exact user match wins over an any user match, but if you have some
> alternate text as a suggestion for the single item that clears that
> up... :)
Ah, I see your thinking now. You want to say "no username has less
precedence than some username, which has less precedence than a path",
so they are all elements of a single list. My thinking was "username
has precedence less than path, and like a shorter path has less
precedence than a longer path, an empty username has less precedence
than a non-empty username".
I agree my suggested wording would need to mention that explicitly.
Like:
. User name (e.g., `user` in `https://user@example.com/repo.git`). If
the config key has a user name it must match the user name in the
URL exactly. If the config key does not have a user name, that
config key will match a URL with any user name (including none), but
at lower precedence than a config key with a user name.
I can live with it either way, though. They are just two ways of
considering the same thing.
> I am considering this text to address that:
>
> >All URLs are normalized (%-encodings are standardized, case-insensitive
> >parts are lowercased, `./` and `../` path components are resolved)
> >before
> >attempting any matching (the password part, if embedded in the URL,
>
> but I'm not sure the extra verbiage makes it better. I think it may
> just complicate the explanation unnecessarily?
Yeah, I think I agree. Let's leave it out.
-Peff
next prev parent reply other threads:[~2013-07-26 22:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 22:39 [REQUEST 0/1] Requesting your signed-off-by Kyle J. McKay
2013-07-25 22:39 ` [REQUEST 1/1] docs: update http.<url>.* options documentation Kyle J. McKay
2013-07-26 4:37 ` Jeff King
2013-07-26 5:53 ` Junio C Hamano
2013-07-26 6:07 ` Junio C Hamano
2013-07-26 6:23 ` Kyle J. McKay
2013-07-26 22:27 ` Jeff King [this message]
2013-07-27 2:15 ` Kyle J. McKay
2013-07-27 2:43 ` Jeff King
2013-07-27 3:04 ` Kyle J. McKay
2013-07-26 6:42 ` Kyle J. McKay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726222732.GA3444@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).