From: Matthijs Kooijman <matthijs@stdin.nl>
To: Eric Wong <normalperson@yhbt.net>
Cc: Gustav Munkby <grddev@gmail.com>,
Edward Rudd <urkle@outoforder.cc>, Carsten Bormann <cabo@tzi.org>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] git-svn: Configure a prompt callback for gnome_keyring.
Date: Tue, 18 Jun 2013 18:36:10 +0200 [thread overview]
Message-ID: <20130618163609.GD10217@login.drsnuggles.stderr.nl> (raw)
In-Reply-To: <20120427082840.GB7257@dcvr.yhbt.net>
Hi folks,
On Fri, Apr 27, 2012 at 08:28:40AM +0000, Eric Wong wrote:
> Matthijs Kooijman <matthijs@stdin.nl> wrote:
> > This allows git-svn to prompt for a keyring unlock password, when a
> > the needed gnome keyring is locked.
> >
> > This requires changes in the subversion perl bindings which have been
> > committed to trunk (1241554 and some followup commits) and should be
> > available with the (as of yet unreleased) 1.8.0 release.
>
> I'm a hesitant to use/depend on unreleased functionality in SVN.
>
> Is there a chance the API could change before the release. Also,
> what kind of tests do the SVN guys do on the Perl bindings + GNOME?
> I'm especially concerned since we just worked around segfault
> bugs in the other patch.
>
> Can we put this on hold until somebody can test the 1.8.0 release?
After over a year, Subversion has finally started with 1.8.0 release
candidates. I've rebased this patch and succesfully tested it against
1.8.0-rc3.
I'll send the updated patch over as a reply to this mail.
As for testing, it took a bit of messing to get all the paths correct,
so I'll document what I did here.
I used a the 1.8.0-rc3 tarball and ran:
subversion-1.8.0-rc3$ ./configure --prefix=/usr/local/svn
subversion-1.8.0-rc3$ make all install
subversion-1.8.0-rc3$ make swig-pl install-swig-pl PREFIX=/usr/local/svn
I took a git master checkout with the patch applied and ran:
git$ make prefix=/usr/local/git all install
Then, inside some git-svn clone, I ran:
$ PERL5LIB=/usr/local/svn/local/lib/perl/5.14.2/ LD_LIBRARY_PATH=/usr/local/svn/lib/ /usr/local/git/bin/git svn rebase
Password for 'default' GNOME keyring:
Current branch master is up to date.
When removing the PERL5LIB and LD_LIBRARY_PATH variables to run against
the system version of subversion (1.6.17 here), I get an authorization
failure as before:
$ /usr/local/git/bin/git svn rebase
Authorization failed: OPTIONS of 'http://svn.example.org': authorization failed: Could not authenticate to server: rejected Basic challenge (http://example.org) at /usr/local/git/share/perl/5.14.2/Git/SVN.pm line 717
Gr.
Matthijs
next prev parent reply other threads:[~2013-06-18 16:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-18 0:36 git-svn won't remember pem password Igor
2012-02-18 11:30 ` Jakub Narebski
2012-02-19 4:03 ` Nikolaus Demmel
2012-02-20 0:57 ` Jeff King
2012-02-20 3:08 ` Nikolaus Demmel
2012-02-19 1:30 ` Eric Wong
2012-04-26 18:00 ` Matthijs Kooijman
[not found] ` <41A093CB-CA4A-4FEF-9F5C-A9B626D10AFB@gmail.com>
[not found] ` <20120426181327.GZ4023@login.drsnuggles.stderr.nl>
2012-04-26 18:31 ` Igor
2012-04-26 18:36 ` Matthijs Kooijman
2012-04-26 19:34 ` [PATCH 1/2] git-svn: use platform specific auth providers Matthijs Kooijman
2012-04-26 19:34 ` [PATCH 2/2] git-svn: Configure a prompt callback for gnome_keyring Matthijs Kooijman
2012-04-27 8:28 ` Eric Wong
2012-04-27 9:36 ` Matthijs Kooijman
2013-06-18 16:36 ` Matthijs Kooijman [this message]
2013-06-18 16:38 ` [PATCH] " Matthijs Kooijman
2013-08-29 9:42 ` Matthijs Kooijman
2013-08-29 17:38 ` Eric Wong
[not found] ` <35AE7D09-F859-4277-AC74-729BA1188D10@outoforder.cc>
2013-08-29 17:56 ` Eric Wong
2012-04-27 8:29 ` [PATCH 2/2] " Matthijs Kooijman
2012-04-27 8:21 ` [PATCH 1/2] git-svn: use platform specific auth providers Eric Wong
2012-04-27 8:25 ` Matthijs Kooijman
2012-04-29 8:23 ` Eric Wong
2012-04-30 0:03 ` Junio C Hamano
2012-04-30 1:21 ` Junio C Hamano
2012-04-30 8:19 ` Eric Wong
2012-04-30 16:04 ` Junio C Hamano
2012-04-30 16:53 ` Matthijs Kooijman
2012-04-30 19:02 ` Eric Wong
2012-04-30 19:20 ` Matthijs Kooijman
2012-05-01 1:08 ` Junio C Hamano
2012-06-03 10:49 ` Charles Bailey
2012-06-03 21:44 ` Junio C Hamano
2012-06-04 9:00 ` Matthijs Kooijman
2012-06-04 19:26 ` Junio C Hamano
2012-06-04 19:36 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618163609.GD10217@login.drsnuggles.stderr.nl \
--to=matthijs@stdin.nl \
--cc=cabo@tzi.org \
--cc=git@vger.kernel.org \
--cc=grddev@gmail.com \
--cc=normalperson@yhbt.net \
--cc=urkle@outoforder.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).