From: Eric Wong <normalperson@yhbt.net>
To: Matthijs Kooijman <matthijs@stdin.nl>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Gustav Munkby <grddev@gmail.com>,
Edward Rudd <urkle@outoforder.cc>, Carsten Bormann <cabo@tzi.org>
Subject: Re: [PATCH 1/2] git-svn: use platform specific auth providers
Date: Mon, 30 Apr 2012 19:02:00 +0000 [thread overview]
Message-ID: <20120430190200.GA27108@dcvr.yhbt.net> (raw)
In-Reply-To: <20120430165315.GO4023@login.drsnuggles.stderr.nl>
Matthijs Kooijman <matthijs@stdin.nl> wrote:
> Hi folks,
>
> I could reproduce this problem (after installing half a dozen Ubuntue perl
> packages on my Debian system ;-p). It seems the problem is because the
> version comparison is wrong:
>
> if ($SVN::Core::VERSION gt '1.6.12') {
>
> This does textual comparison, so 1.6.6 > 1.6.12. To do proper version
> comparison, I think the version numbers should be split into
> major/minor/revision and each be compared numerically.
>
> This is not the only place where this comparison happens in this way,
> there are 6 more comparisons in this way, which would have to be fixed
> as well.
Ah, thanks for the analysis, we were lucky in the past that all version
components only had a single character.
> We could introduce a helper function for comparing version numbers by
> splitting and comparing the parts separately, but that might be hard to
> get right (especially when non-numeric version parts are involved).
>
> An alternative would be to use the Sort::Versions perl module [1] for
> this, but that would add an external dependency.
>
> I'd be happy to code and test both approaches, just let me know which
> would be preferred.
I think the former is preferable for git. Sort::Versions isn't used
anywhere else in git and I don't think it's widely installed.
next prev parent reply other threads:[~2012-04-30 19:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-18 0:36 git-svn won't remember pem password Igor
2012-02-18 11:30 ` Jakub Narebski
2012-02-19 4:03 ` Nikolaus Demmel
2012-02-20 0:57 ` Jeff King
2012-02-20 3:08 ` Nikolaus Demmel
2012-02-19 1:30 ` Eric Wong
2012-04-26 18:00 ` Matthijs Kooijman
[not found] ` <41A093CB-CA4A-4FEF-9F5C-A9B626D10AFB@gmail.com>
[not found] ` <20120426181327.GZ4023@login.drsnuggles.stderr.nl>
2012-04-26 18:31 ` Igor
2012-04-26 18:36 ` Matthijs Kooijman
2012-04-26 19:34 ` [PATCH 1/2] git-svn: use platform specific auth providers Matthijs Kooijman
2012-04-26 19:34 ` [PATCH 2/2] git-svn: Configure a prompt callback for gnome_keyring Matthijs Kooijman
2012-04-27 8:28 ` Eric Wong
2012-04-27 9:36 ` Matthijs Kooijman
2013-06-18 16:36 ` Matthijs Kooijman
2013-06-18 16:38 ` [PATCH] " Matthijs Kooijman
2013-08-29 9:42 ` Matthijs Kooijman
2013-08-29 17:38 ` Eric Wong
[not found] ` <35AE7D09-F859-4277-AC74-729BA1188D10@outoforder.cc>
2013-08-29 17:56 ` Eric Wong
2012-04-27 8:29 ` [PATCH 2/2] " Matthijs Kooijman
2012-04-27 8:21 ` [PATCH 1/2] git-svn: use platform specific auth providers Eric Wong
2012-04-27 8:25 ` Matthijs Kooijman
2012-04-29 8:23 ` Eric Wong
2012-04-30 0:03 ` Junio C Hamano
2012-04-30 1:21 ` Junio C Hamano
2012-04-30 8:19 ` Eric Wong
2012-04-30 16:04 ` Junio C Hamano
2012-04-30 16:53 ` Matthijs Kooijman
2012-04-30 19:02 ` Eric Wong [this message]
2012-04-30 19:20 ` Matthijs Kooijman
2012-05-01 1:08 ` Junio C Hamano
2012-06-03 10:49 ` Charles Bailey
2012-06-03 21:44 ` Junio C Hamano
2012-06-04 9:00 ` Matthijs Kooijman
2012-06-04 19:26 ` Junio C Hamano
2012-06-04 19:36 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430190200.GA27108@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=cabo@tzi.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=grddev@gmail.com \
--cc=matthijs@stdin.nl \
--cc=urkle@outoforder.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).