From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Benoît Person" <benoit.person@ensimag.fr>,
git@vger.kernel.org, "Célestin Matte" <celestin.matte@ensimag.fr>
Subject: Re: [PATCH/RFC] git-remote-mediawiki: new tool to preview local changes without pushing
Date: Wed, 12 Jun 2013 04:55:02 -0400 [thread overview]
Message-ID: <20130612085502.GA1935@sigill.intra.peff.net> (raw)
In-Reply-To: <vpqli6f24z3.fsf@anie.imag.fr>
On Wed, Jun 12, 2013 at 08:55:12AM +0200, Matthieu Moy wrote:
> > But I think we have already crossed that bridge somewhat with Git.pm.
> > And if you add your module as perl/Git/MediaWiki.pm and use the existing
> > perl build system, then it is not any extra effort from the build
> > system.
>
> I'm not sure having perl/Git/MediaWiki.pm would be a good idea: this
> MediaWiki.pm would be really a mediawiki thing more than a Git thing, so
> the Git main tree probably want to stay away from it and keep it in
> contrib.
Yes, it's ugly. It means that the mediawiki stuff creeps out of contrib
and into the main tree; and worse, as part of a public API that gets
installed. We'd have to be a lot more picky about the interface and the
code quality.
> But you should be able to use contrib/mw-to-git/perl/GitMediawiki.pm or
> something like that and chain to ../../perl/Makefile in
> contrib/mw-to-git/Makefile.
That might work. Most of the magic in perl/Makefile happens in the
perl-generated MakeMaker bits, though, so it may not be that easy. I
haven't looked.
> Also, for now, git-remote-mediawiki works only after you run "make
> install" in Git's toplevel. I think that's ok, but it would be weird to
> be able to use/test git-remote-mediawiki only after doing a "make
> install" to deploy the new mediawiki Perl module.
Good point.
-Peff
prev parent reply other threads:[~2013-06-12 8:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 21:50 [PATCH/RFC] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person
2013-06-08 19:00 ` Matthieu Moy
2013-06-09 6:12 ` Jeff King
2013-06-09 6:08 ` Jeff King
2013-06-09 11:01 ` Matthieu Moy
2013-06-09 12:18 ` Benoît Person
2013-06-09 18:13 ` Jeff King
2013-06-09 12:35 ` Benoît Person
2013-06-09 14:37 ` Matthieu Moy
2013-06-09 18:32 ` Jeff King
2013-06-11 21:31 ` Benoît Person
2013-06-11 21:37 ` Jeff King
2013-06-12 6:55 ` Matthieu Moy
2013-06-12 8:55 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612085502.GA1935@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=celestin.matte@ensimag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).