From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: benoit.person@ensimag.fr, git@vger.kernel.org, celestin.matte@ensimag.fr
Subject: Re: [PATCH/RFC] git-remote-mediawiki: new tool to preview local changes without pushing
Date: Sun, 9 Jun 2013 02:12:22 -0400 [thread overview]
Message-ID: <20130609061222.GB8906@sigill.intra.peff.net> (raw)
In-Reply-To: <vpqzjv0tokx.fsf@anie.imag.fr>
On Sat, Jun 08, 2013 at 09:00:30PM +0200, Matthieu Moy wrote:
> > + # Auto-loading in browser
> > + if ($autoload) {
> > + open(my $browser, "-|:encoding(UTF-8)", "xdg-open ".$preview_file_name);
>
> That could be read from Git's configuration, and default to xdg-open.
> But you don't want to hardcode it in the middle of the code.
In fact, I think we provide the "git-web--browse" tool for just this
purpose. It takes care of the trickiness of looking at the "web.browser"
config, resolving custom browser tools defined by "browser.<tool>.*",
and handling backgrounding of the browser (which you want to do for
graphical browsers but not for terminal ones).
-Peff
PS I agreed with all of the other comments in your review. :)
next prev parent reply other threads:[~2013-06-09 6:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 21:50 [PATCH/RFC] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person
2013-06-08 19:00 ` Matthieu Moy
2013-06-09 6:12 ` Jeff King [this message]
2013-06-09 6:08 ` Jeff King
2013-06-09 11:01 ` Matthieu Moy
2013-06-09 12:18 ` Benoît Person
2013-06-09 18:13 ` Jeff King
2013-06-09 12:35 ` Benoît Person
2013-06-09 14:37 ` Matthieu Moy
2013-06-09 18:32 ` Jeff King
2013-06-11 21:31 ` Benoît Person
2013-06-11 21:37 ` Jeff King
2013-06-12 6:55 ` Matthieu Moy
2013-06-12 8:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609061222.GB8906@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=celestin.matte@ensimag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).