From: Matthijs Kooijman <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: Duy Nguyen <email@example.com>, Jonathan Nieder <firstname.lastname@example.org>, Stefan Beller <email@example.com>, firstname.lastname@example.org, Ralf.Wildenhues@gmx.de, email@example.com Subject: Re: [PATCH] git clone depth of 0 not possible. Date: Tue, 28 May 2013 11:18:12 +0200 [thread overview] Message-ID: <20130528091812.GG25742@login.drsnuggles.stderr.nl> (raw) In-Reply-To: <firstname.lastname@example.org> Hi Junio, I'm interested in getting a fetch tip commit only feature into git, I'll probably look into creating a patch for this. > >>> Sounds buggy. Would anything break if we were to make --depth=1 mean > >>> "1 deep, including the tip commit"? > >> > >> As long as we do not change the meaning of the "shallow" count going > >> over the wire (i.e. the number we receive from the user will be > >> fudged, so that user's "depth 1" that used to mean "the tip and one > >> behind it" is expressed as "depth 2" at the end-user level, and we > >> send over the wire the number that corresponded to the old "depth > >> 1"), I do not think anything will break, and then --depth=0 may > >> magically start meaning "only the tip; its immediate parents will > >> not be transferred and recorded as the shallow boundary in the > >> receiving repository". > > > > I'd rather we reserve 0 for unlimited fetch, something we haven't done > > so far . And because "unlimited clone" with --depth does not make > > sense, --depth=0 should be rejected by git-clone. > > I actually was thinking about changing --depth=1 to mean "the tip, > with zero commits behind it" (and that was consistent with my > description of "fudging"), but ended up saying "--depth=0" by > mistake. I too think "--depth=0" or "--depth<0" does not make > sense, so we are in agreement. Did you consider how to implement this? Looking at the code, it seems the "deepen" parameter in the wire protocol now means: - 0: Do not change anything about the shallowness (i.e., fetch everything from the shallow root to the tip). - > 0: Create new shallow commits at depth commits below the tip (so depth == 1 means tip and one below). - INFINITE_DEPTH (0x7fffffff): Remove all shallowness and fetch complete history. Given this, I'm not sure how one can express "fetch the tip and nothing below that", since depth == 0 already has a different meaning. Of course, one could using depth == 1 in this case to receive two commits and then drop one, but this would seem a bit pointless to me (especially if the commit below the tip is very different from the tip leading to a lot of useless data transfer). Or did I misunderstand something here? Gr. Matthijs
next prev parent reply other threads:[~2013-05-28 9:18 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-07 18:06 Stefan Beller 2013-01-07 18:06 ` [PATCH] Documentation on depth option in git clone Stefan Beller 2013-01-08 6:28 ` [PATCH] git clone depth of 0 not possible Jonathan Nieder 2013-01-08 6:54 ` Junio C Hamano 2013-01-08 7:36 ` Junio C Hamano 2013-01-08 8:19 ` Junio C Hamano 2013-01-08 14:28 ` Duy Nguyen 2013-01-08 14:32 ` Stefan Beller 2013-01-08 14:45 ` Duy Nguyen 2013-01-08 17:24 ` Junio C Hamano 2013-01-08 7:38 ` Duy Nguyen 2013-01-08 8:05 ` Junio C Hamano 2013-05-28 9:18 ` Matthijs Kooijman [this message] 2013-05-28 16:28 ` Jonathan Nieder 2013-05-28 16:31 ` Jonathan Nieder 2013-05-28 16:34 ` Matthijs Kooijman 2013-05-28 16:58 ` Jonathan Nieder 2013-05-28 17:04 ` Junio C Hamano 2013-05-30 8:23 ` Matthijs Kooijman 2013-06-02 19:14 ` Junio C Hamano 2013-07-09 13:35 ` Matthijs Kooijman 2013-07-11 10:57 ` Matthijs Kooijman 2013-07-11 11:25 ` [PATCH 1/3] upload-pack: Remove a piece of dead code Matthijs Kooijman 2013-07-11 11:25 ` [PATCH 2/3] upload-pack: Introduce new "fixed-off-by-one-depth" server feature Matthijs Kooijman 2013-07-11 11:25 ` [PATCH 3/3] fetch-pack: Request fixed-off-by-one-depth when available Matthijs Kooijman 2013-07-11 12:08 ` [PATCH 1/3] upload-pack: Remove a piece of dead code Duy Nguyen 2013-07-11 15:49 ` Junio C Hamano 2013-01-08 7:33 ` [PATCH] git clone depth of 0 not possible Duy Nguyen 2013-01-08 7:37 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130528091812.GG25742@login.drsnuggles.stderr.nl \ --email@example.com \ --cc=Ralf.Wildenhues@gmx.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] git clone depth of 0 not possible.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).