From: Junio C Hamano <firstname.lastname@example.org> To: Stefan Beller <email@example.com> Cc: Duy Nguyen <firstname.lastname@example.org>, Jonathan Nieder <email@example.com>, firstname.lastname@example.org, Ralf.Wildenhues@gmx.de, email@example.com Subject: Re: [PATCH] git clone depth of 0 not possible. Date: Tue, 08 Jan 2013 09:24:16 -0800 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <50EC2DE5.email@example.com> (Stefan Beller's message of "Tue, 08 Jan 2013 15:32:05 +0100") Stefan Beller <firstname.lastname@example.org> writes: > On 01/08/2013 03:28 PM, Duy Nguyen wrote: >> On Tue, Jan 8, 2013 at 2:36 PM, Junio C Hamano <email@example.com> wrote: >>> Speaking of --depth, I think in Git 2.0 we should fix the semantics >>> of "deepening" done with "git fetch". >> >> Speaking of 2.0, we should support depth per ref. Well we don't have >> to wait until 2.0 because we could just add shallow2 extension to the >> pack protocol. We should also apply depth to new refs when fetching >> them the first time. > > Would this mean I could do something along? > $ git clone --since v1.8.0 git://github.com/gitster/git.git > > So tags would be allowed as anchors? As the end-user facing UI, I think it would be much easier to use for users who want to get only the recent part of history that is relevant to their development if you allowed them to ask "starting from this one, I do not care anything older than that" with such an interface. The current "count how many more generations you want" interface is crazy in that it forces you to count what you have not even seen; I suspect the only reason it was done in such a hacky manner was implementation expediency. At the syntax level, however, I do not think we can use --since there, because the keyword has a very different meaning already. I personally do not think "depth per ref" deserves "it would be nice to support in 2.0", let alone "2.0 *should* support", label. Some may find it an interesting mental exercise to think about corner cases it will introduce and have to deal with (e.g. you ask 100 from master and 2 from maint, but maint is behind master by less than 100---what should happen?), but I do not particularly see any practical use cases, and I highly doubt that there is much value in bringing in extra complexity such a "feature" requires to do it right.
next prev parent reply other threads:[~2013-01-08 17:24 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-07 18:06 Stefan Beller 2013-01-07 18:06 ` [PATCH] Documentation on depth option in git clone Stefan Beller 2013-01-08 6:28 ` [PATCH] git clone depth of 0 not possible Jonathan Nieder 2013-01-08 6:54 ` Junio C Hamano 2013-01-08 7:36 ` Junio C Hamano 2013-01-08 8:19 ` Junio C Hamano 2013-01-08 14:28 ` Duy Nguyen 2013-01-08 14:32 ` Stefan Beller 2013-01-08 14:45 ` Duy Nguyen 2013-01-08 17:24 ` Junio C Hamano [this message] 2013-01-08 7:38 ` Duy Nguyen 2013-01-08 8:05 ` Junio C Hamano 2013-05-28 9:18 ` Matthijs Kooijman 2013-05-28 16:28 ` Jonathan Nieder 2013-05-28 16:31 ` Jonathan Nieder 2013-05-28 16:34 ` Matthijs Kooijman 2013-05-28 16:58 ` Jonathan Nieder 2013-05-28 17:04 ` Junio C Hamano 2013-05-30 8:23 ` Matthijs Kooijman 2013-06-02 19:14 ` Junio C Hamano 2013-07-09 13:35 ` Matthijs Kooijman 2013-07-11 10:57 ` Matthijs Kooijman 2013-07-11 11:25 ` [PATCH 1/3] upload-pack: Remove a piece of dead code Matthijs Kooijman 2013-07-11 11:25 ` [PATCH 2/3] upload-pack: Introduce new "fixed-off-by-one-depth" server feature Matthijs Kooijman 2013-07-11 11:25 ` [PATCH 3/3] fetch-pack: Request fixed-off-by-one-depth when available Matthijs Kooijman 2013-07-11 12:08 ` [PATCH 1/3] upload-pack: Remove a piece of dead code Duy Nguyen 2013-07-11 15:49 ` Junio C Hamano 2013-01-08 7:33 ` [PATCH] git clone depth of 0 not possible Duy Nguyen 2013-01-08 7:37 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Ralf.Wildenhues@gmx.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] git clone depth of 0 not possible.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).