* git-send-email doesn't deal with quoted names
@ 2013-05-27 23:40 Jason A. Donenfeld
2013-05-28 8:25 ` John Keeping
0 siblings, 1 reply; 2+ messages in thread
From: Jason A. Donenfeld @ 2013-05-27 23:40 UTC (permalink / raw)
To: git
Hi,
My commit author name is "Jason A. Donenfeld". Because this has a dot,
SMTP handling likes to put it in quotes.
git-send-email has this line:
if (defined $author and $author ne $sender) {
With my name, this always winds up false, because it's comparing
'"Jason A. Donenfeld" <Jason@zx2c4.com>' with 'Jason A. Donenfeld
<Jason@zx2c4.com>'.
So, the logic needs to be fixed somehow.
Thanks,
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: git-send-email doesn't deal with quoted names
2013-05-27 23:40 git-send-email doesn't deal with quoted names Jason A. Donenfeld
@ 2013-05-28 8:25 ` John Keeping
0 siblings, 0 replies; 2+ messages in thread
From: John Keeping @ 2013-05-28 8:25 UTC (permalink / raw)
To: Jason A. Donenfeld; +Cc: git
On Tue, May 28, 2013 at 01:40:20AM +0200, Jason A. Donenfeld wrote:
> My commit author name is "Jason A. Donenfeld". Because this has a dot,
> SMTP handling likes to put it in quotes.
>
> git-send-email has this line:
> if (defined $author and $author ne $sender) {
>
> With my name, this always winds up false, because it's comparing
> '"Jason A. Donenfeld" <Jason@zx2c4.com>' with 'Jason A. Donenfeld
> <Jason@zx2c4.com>'.
>
> So, the logic needs to be fixed somehow.
There was a patch for this recently, although it appears to be still
under discussion:
http://article.gmane.org/gmane.comp.version-control.git/225247
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-28 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-27 23:40 git-send-email doesn't deal with quoted names Jason A. Donenfeld
2013-05-28 8:25 ` John Keeping
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).