git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] fix compilation with NO_PTHREADS
@ 2013-01-05 14:52 Jeff King
  2013-01-05 23:40 ` Jonathan Nieder
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff King @ 2013-01-05 14:52 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

Commit 1327452 cleaned up an unused parameter from
wait_or_whine, but forgot to update a caller that is inside
"#ifdef NO_PTHREADS".

Signed-off-by: Jeff King <peff@peff.net>
---
I happened to notice this while looking at the sigpipe topic. I guess
not many people are building with NO_PTHREADS these days.

 run-command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/run-command.c b/run-command.c
index cfb7274..0471219 100644
--- a/run-command.c
+++ b/run-command.c
@@ -725,7 +725,7 @@ int finish_async(struct async *async)
 int finish_async(struct async *async)
 {
 #ifdef NO_PTHREADS
-	return wait_or_whine(async->pid, "child process", 0);
+	return wait_or_whine(async->pid, "child process");
 #else
 	void *ret = (void *)(intptr_t)(-1);
 
-- 
1.8.1.rc1.16.g6d46841

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix compilation with NO_PTHREADS
  2013-01-05 14:52 [PATCH] fix compilation with NO_PTHREADS Jeff King
@ 2013-01-05 23:40 ` Jonathan Nieder
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2013-01-05 23:40 UTC (permalink / raw)
  To: Jeff King; +Cc: Junio C Hamano, git

Jeff King wrote:

> I happened to notice this while looking at the sigpipe topic. I guess
> not many people are building with NO_PTHREADS these days.

Or that those people don't build "next". :)

Thanks for catching it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-01-05 23:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-05 14:52 [PATCH] fix compilation with NO_PTHREADS Jeff King
2013-01-05 23:40 ` Jonathan Nieder

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).