From: Jeff King <peff@peff.net>
To: Adam Spiers <git@adamspiers.org>
Cc: Junio C Hamano <gitster@pobox.com>, git list <git@vger.kernel.org>
Subject: Re: [PATCH v6 0/7] make test output coloring more intuitive
Date: Thu, 20 Dec 2012 10:34:11 -0500 [thread overview]
Message-ID: <20121220153411.GA1497@sigill.intra.peff.net> (raw)
In-Reply-To: <CAOkDyE9B_HfUZmqNqO35mtjTvdihBTiW=uOV2oEQgLUw1xyf=A@mail.gmail.com>
On Sun, Dec 16, 2012 at 07:01:56PM +0000, Adam Spiers wrote:
> On Sun, Dec 16, 2012 at 6:54 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > Adam Spiers <git@adamspiers.org> writes:
> >
> >> This series of commits attempts to make test output coloring
> >> more intuitive,...
> >
> > Thanks; I understand that this is to replace the previous one
> > b465316 (tests: paint unexpectedly fixed known breakages in bold
> > red, 2012-09-19)---am I correct?
>
> Correct. AFAICS I have incorporated all feedback raised in previous
> reviews.
>
> > Will take a look; thanks.
>
> Thanks. Sorry again for the delay. I'm now (finally) resuming work
> on as/check-ignore.
I eyeballed the test output of "pu". I do think this resolves all of the
issues brought up before, and I really hate to bikeshed on the colors at
this point, but I find that bold cyan a bit hard on the eyes when
running with "-v" (where most of the output is in that color, as it
dumps the shell for each test). Is there any reason not to tone it down
a bit like:
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 256f1c6..31f59af 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -227,7 +227,7 @@ then
pass)
tput setaf 2;; # green
info)
- tput bold; tput setaf 6;; # bold cyan
+ tput setaf 6;; # cyan
*)
test -n "$quiet" && return;;
esac
-Peff
next prev parent reply other threads:[~2012-12-20 15:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 18:28 [PATCH v6 0/7] make test output coloring more intuitive Adam Spiers
2012-12-16 18:28 ` [PATCH v6 1/7] tests: test number comes first in 'not ok $count - $message' Adam Spiers
2012-12-16 18:28 ` [PATCH v6 2/7] tests: paint known breakages in bold yellow Adam Spiers
2012-12-16 18:28 ` [PATCH v6 3/7] tests: paint skipped tests in bold blue Adam Spiers
2012-12-16 18:28 ` [PATCH v6 4/7] tests: change info messages from yellow/brown to bold cyan Adam Spiers
2012-12-16 18:28 ` [PATCH v6 5/7] tests: refactor mechanics of testing in a sub test-lib Adam Spiers
2012-12-16 18:28 ` [PATCH v6 6/7] tests: test the test framework more thoroughly Adam Spiers
2012-12-16 18:28 ` [PATCH v6 7/7] tests: paint unexpectedly fixed known breakages in bold red Adam Spiers
2012-12-16 18:54 ` [PATCH v6 0/7] make test output coloring more intuitive Junio C Hamano
2012-12-16 19:01 ` Adam Spiers
2012-12-16 23:11 ` Junio C Hamano
2012-12-20 15:34 ` Jeff King [this message]
2012-12-20 15:44 ` Adam Spiers
2012-12-20 16:11 ` Jeff King
2012-12-20 18:08 ` Adam Spiers
2012-12-20 19:21 ` Junio C Hamano
2012-12-20 19:50 ` Jeff King
2012-12-20 23:28 ` Adam Spiers
2012-12-21 3:12 ` [PATCH v7 0/7] coloring test output after traffic signal Junio C Hamano
2012-12-21 8:15 ` Jeff King
2012-12-21 10:00 ` Adam Spiers
2012-12-21 3:12 ` [PATCH v7 1/7] tests: test number comes first in 'not ok $count - $message' Junio C Hamano
2012-12-21 3:12 ` [PATCH v7 2/7] tests: paint known breakages in yellow Junio C Hamano
2012-12-21 8:51 ` Stefano Lattarini
2012-12-21 15:46 ` Junio C Hamano
2012-12-21 16:59 ` Stefano Lattarini
2012-12-21 3:12 ` [PATCH v7 3/7] tests: paint skipped tests in blue Junio C Hamano
2012-12-21 3:12 ` [PATCH v7 4/7] tests: change info messages from yellow/brown to cyan Junio C Hamano
2012-12-21 3:12 ` [PATCH v7 5/7] tests: refactor mechanics of testing in a sub test-lib Junio C Hamano
2012-12-21 3:12 ` [PATCH v7 6/7] tests: test the test framework more thoroughly Junio C Hamano
2012-12-21 3:12 ` [PATCH v7 7/7] tests: paint unexpectedly fixed known breakages in bold red Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220153411.GA1497@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@adamspiers.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).