From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v3 4/4] fast-export: make sure refs are updated properly
Date: Fri, 2 Nov 2012 07:55:55 -0700 [thread overview]
Message-ID: <20121102145555.GA14774@elie.Belkin> (raw)
In-Reply-To: <20121102131255.GB2598@sigill.intra.peff.net>
Jeff King wrote:
> If so, then this series isn't regressing behavior; the only downside is
> that it's an incomplete fix. In theory this could get in the way of the
> full fix later on, but given the commit messages and the archive of this
> discussion, it would be simple enough to revert it later in favor of a
> more full fix. Is that accurate?
>
> Sorry if I am belaboring the discussion. I just want to make sure I
> understand the situation before deciding what to do with the topic. It
> sounds like the consensus at this point is "not perfect, but good enough
> to make forward progress".
Patch 1, 2, and 4 are good modulo their descriptions. They should
work fine without patch 3.
Patch 3 is a regression in comprehensibility. I think we can do
better. Maybe all it would take is a less confusing description, and
tweaks to the code (to loop over revs->cmdline instead of
revs->pending) could come on top.
next prev parent reply other threads:[~2012-11-02 14:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 19:06 [PATCH v3 0/4] fast-export: general fixes Felipe Contreras
2012-10-30 19:06 ` [PATCH v3 1/4] fast-export: trivial cleanup Felipe Contreras
2012-10-30 19:06 ` [PATCH v3 2/4] fast-export: fix comparisson in tests Felipe Contreras
2012-10-30 19:06 ` [PATCH v3 3/4] fast-export: don't handle uninteresting refs Felipe Contreras
2012-10-30 19:06 ` [PATCH v3 4/4] fast-export: make sure refs are updated properly Felipe Contreras
2012-10-31 0:11 ` [PATCH v2 " Jonathan Nieder
2012-10-31 2:08 ` Felipe Contreras
2012-10-31 0:37 ` [PATCH v3 " Jonathan Nieder
2012-10-31 1:33 ` Sverre Rabbelier
2012-10-31 6:05 ` Jonathan Nieder
2012-10-31 9:53 ` [OT] How to get the discussion details via notes Peter Baumann
2012-10-31 12:29 ` Drew Northup
2012-10-31 14:10 ` Jeff King
2012-11-01 7:49 ` Peter Baumann
2012-10-31 2:13 ` [PATCH v3 4/4] fast-export: make sure refs are updated properly Felipe Contreras
2012-11-02 13:12 ` Jeff King
2012-11-02 14:55 ` Jonathan Nieder [this message]
2012-11-02 15:17 ` Johannes Schindelin
2012-11-02 15:19 ` Jeff King
2012-11-02 15:35 ` Felipe Contreras
2012-11-02 15:34 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102145555.GA14774@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).