From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Elijah Newren <newren@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v3 1/4] fast-export: trivial cleanup
Date: Tue, 30 Oct 2012 20:06:24 +0100 [thread overview]
Message-ID: <1351623987-21012-2-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1351623987-21012-1-git-send-email-felipe.contreras@gmail.com>
Setting commit to commit is a no-op. It might have been there to avoid a
compiler warning, but if so, it was the compiler to blame.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
builtin/fast-export.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index 12220ad..065f324 100644
--- a/builtin/fast-export.c
+++ b/builtin/fast-export.c
@@ -483,7 +483,7 @@ static void get_tags_and_duplicates(struct object_array *pending,
for (i = 0; i < pending->nr; i++) {
struct object_array_entry *e = pending->objects + i;
unsigned char sha1[20];
- struct commit *commit = commit;
+ struct commit *commit;
char *full_name;
if (dwim_ref(e->name, strlen(e->name), sha1, &full_name) != 1)
--
1.8.0
next prev parent reply other threads:[~2012-10-30 19:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 19:06 [PATCH v3 0/4] fast-export: general fixes Felipe Contreras
2012-10-30 19:06 ` Felipe Contreras [this message]
2012-10-30 19:06 ` [PATCH v3 2/4] fast-export: fix comparisson in tests Felipe Contreras
2012-10-30 19:06 ` [PATCH v3 3/4] fast-export: don't handle uninteresting refs Felipe Contreras
2012-10-30 19:06 ` [PATCH v3 4/4] fast-export: make sure refs are updated properly Felipe Contreras
2012-10-31 0:11 ` [PATCH v2 " Jonathan Nieder
2012-10-31 2:08 ` Felipe Contreras
2012-10-31 0:37 ` [PATCH v3 " Jonathan Nieder
2012-10-31 1:33 ` Sverre Rabbelier
2012-10-31 6:05 ` Jonathan Nieder
2012-10-31 9:53 ` [OT] How to get the discussion details via notes Peter Baumann
2012-10-31 12:29 ` Drew Northup
2012-10-31 14:10 ` Jeff King
2012-11-01 7:49 ` Peter Baumann
2012-10-31 2:13 ` [PATCH v3 4/4] fast-export: make sure refs are updated properly Felipe Contreras
2012-11-02 13:12 ` Jeff King
2012-11-02 14:55 ` Jonathan Nieder
2012-11-02 15:17 ` Johannes Schindelin
2012-11-02 15:19 ` Jeff King
2012-11-02 15:35 ` Felipe Contreras
2012-11-02 15:34 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351623987-21012-2-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).