From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: David Michael Barr <davidbarr@google.com>,
Florian Achleitner <florian.achleitner2.6.31@gmail.com>,
git@vger.kernel.org
Subject: [PATCH 4/9] vcs-svn: use constcmp instead of prefixcmp
Date: Fri, 6 Jul 2012 12:18:38 -0500 [thread overview]
Message-ID: <20120706171838.GE31001@burratino> (raw)
In-Reply-To: <20120706171040.GA31001@burratino>
From: David Barr <davidbarr@google.com>
Date: Fri, 1 Jun 2012 00:41:27 +1000
Since the length of t is already known, we can simplify a little by
using memcmp() instead of strncmp() to carry out a prefix comparison.
All nearby code already does this.
Noticed in the standalone svn-dump-fast-export project which has not
needed to implement prefixcmp() yet.
Signed-off-by: David Barr <davidbarr@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Description clarified. No other change.
vcs-svn/svndump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c
index f6c0d4c8..c5d07a66 100644
--- a/vcs-svn/svndump.c
+++ b/vcs-svn/svndump.c
@@ -361,7 +361,7 @@ void svndump_read(const char *url)
reset_rev_ctx(atoi(val));
break;
case sizeof("Node-path"):
- if (prefixcmp(t, "Node-"))
+ if (constcmp(t, "Node-"))
continue;
if (!constcmp(t + strlen("Node-"), "path")) {
if (active_ctx == NODE_CTX)
--
1.7.10.4
next prev parent reply other threads:[~2012-07-06 17:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 21:55 What's cooking in git.git (Jun 2012, #02; Wed, 6) Junio C Hamano
2012-06-06 23:49 ` David Michael Barr
2012-06-07 0:39 ` Jonathan Nieder
2012-06-07 5:25 ` Junio C Hamano
2012-07-06 17:10 ` [GIT PULL] vcs-svn housekeeping Jonathan Nieder
2012-07-06 17:13 ` [PATCH 1/9] vcs-svn: drop no-op reset methods Jonathan Nieder
2012-07-06 17:16 ` [PATCH 2/9] vcs-svn: avoid self-assignment in dummy initialization of pre_off Jonathan Nieder
2012-07-06 17:18 ` [PATCH 3/9] vcs-svn: simplify cleanup in apply_one_window Jonathan Nieder
2012-07-06 17:18 ` Jonathan Nieder [this message]
2012-07-06 17:19 ` [PATCH 5/9] vcs-svn: use strstr instead of memmem Jonathan Nieder
2012-07-06 17:21 ` [PATCH 6/9] vcs-svn: suppress signed/unsigned comparison warnings Jonathan Nieder
2012-07-06 17:22 ` [PATCH 7/9] vcs-svn: suppress a signed/unsigned comparison warning Jonathan Nieder
2012-07-06 17:25 ` [PATCH 8/9] " Jonathan Nieder
2012-07-06 17:27 ` [PATCH 9/9] vcs-svn: allow 64-bit Prop-Content-Length Jonathan Nieder
2012-07-06 19:41 ` [GIT PULL] vcs-svn housekeeping David Michael Barr
2012-07-06 20:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706171838.GE31001@burratino \
--to=jrnieder@gmail.com \
--cc=davidbarr@google.com \
--cc=florian.achleitner2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).