From: Jonathan Nieder <jrnieder@gmail.com>
To: David Michael Barr <davidbarr@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2012, #02; Wed, 6)
Date: Wed, 6 Jun 2012 19:39:04 -0500 [thread overview]
Message-ID: <20120607003904.GB4065@burratino> (raw)
In-Reply-To: <CAFfmPPOWZz8JF_BVKvnAVp0VUDzxPiVSqjG7ATPx3CVztDF=cw@mail.gmail.com>
Hi,
David Michael Barr wrote:
> On Thu, Jun 7, 2012 at 7:55 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> * db/vcs-svn (2012-06-01) 6 commits
>> - vcs-svn: drop no-op reset methods
>> - vcs-svn: fix signedness warnings
>> - vcs-svn: prefer strstr over memmem
>> - vcs-svn: prefer constcmp to prefixcmp
>> - vcs-svn: simplify cleanup in apply_one_window()
>> - vcs-svn: fix clang-analyzer error
>>
>> I do not know the doneness of this series that came out of the
>> blue. Are people involved in vcs-svn happy with this series?
>
> At the end of this series, vcs-svn is static-analyzer clean when
> merged into svn-dump-fast-export.
Thanks for the cc. I generally like the code and generally dislike
the descriptions which amount to "appease the static analyzer" and
don't reflect the thought you actually put into the patches, which
sets a bad precedent. I was planning to munge the descriptions, ask
you to look it over, and then ask Junio to pull.
The signedness patch still leaves me worried: for example, where len
is of type (size_t) and delta_len of type (off_t *),
- if (len > *delta_len ||
+ if ((off_t) len > *delta_len ||
changes the meaning for the worse if len is very large on a system
(think: 64-bit PC) where size_t and off_t have the same width. It's
exploitable. :(
But I like the spirit of the patches.
The "drop no-op reset methods" patch is unrisky and could go in
directly.
Jonathan
next prev parent reply other threads:[~2012-06-07 0:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 21:55 What's cooking in git.git (Jun 2012, #02; Wed, 6) Junio C Hamano
2012-06-06 23:49 ` David Michael Barr
2012-06-07 0:39 ` Jonathan Nieder [this message]
2012-06-07 5:25 ` Junio C Hamano
2012-07-06 17:10 ` [GIT PULL] vcs-svn housekeeping Jonathan Nieder
2012-07-06 17:13 ` [PATCH 1/9] vcs-svn: drop no-op reset methods Jonathan Nieder
2012-07-06 17:16 ` [PATCH 2/9] vcs-svn: avoid self-assignment in dummy initialization of pre_off Jonathan Nieder
2012-07-06 17:18 ` [PATCH 3/9] vcs-svn: simplify cleanup in apply_one_window Jonathan Nieder
2012-07-06 17:18 ` [PATCH 4/9] vcs-svn: use constcmp instead of prefixcmp Jonathan Nieder
2012-07-06 17:19 ` [PATCH 5/9] vcs-svn: use strstr instead of memmem Jonathan Nieder
2012-07-06 17:21 ` [PATCH 6/9] vcs-svn: suppress signed/unsigned comparison warnings Jonathan Nieder
2012-07-06 17:22 ` [PATCH 7/9] vcs-svn: suppress a signed/unsigned comparison warning Jonathan Nieder
2012-07-06 17:25 ` [PATCH 8/9] " Jonathan Nieder
2012-07-06 17:27 ` [PATCH 9/9] vcs-svn: allow 64-bit Prop-Content-Length Jonathan Nieder
2012-07-06 19:41 ` [GIT PULL] vcs-svn housekeeping David Michael Barr
2012-07-06 20:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607003904.GB4065@burratino \
--to=jrnieder@gmail.com \
--cc=davidbarr@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).