git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Alexey Shumkin <zapped@mail.ru>
Cc: git@vger.kernel.org, Gerrit Pape <pape@smarden.org>,
	Johannes Sixt <j6t@kdbg.org>,
	Michael Haggerty <mhagger@alum.mit.edu>,
	Jon Jensen <jon@endpoint.com>
Subject: Re: [PATCH 2/2] post-receive-email: defend against non UTF-8 i18n.logoutputencoding setting
Date: Wed, 14 Mar 2012 14:55:09 -0500	[thread overview]
Message-ID: <20120314195509.GA31686@burratino> (raw)
In-Reply-To: <20120314233609.04a2a37b@zappedws>

Alexey Shumkin wrote:

> I'd like to remind then following aspect
>
>> My proposition was in to send email message in explicitly defined
>> custom encoding. Why? In development process under Windows non-UTF-8
>> encoding is used (cp1251 in my case). So, filenames have this
>> encoding, and as we know Git stores their names as is
[...]
>>                                                                 with
>> core.quotepath= false

Sure.  Do you think this patch makes that problem worse, and if so, do
you have any ideas about how that could be prevented?  Otherwise:

>>            Making the email charset configurable is left as an
>> exercise for the interested reader.

I did not want to do that part because I do not trust myself to
understand the needs of people using non-utf8 and test it
appropriately, but I tried to make sure the patch was structured in a
way that would make it easy.

Hoping clarifies a little,
Jonathan

  reply	other threads:[~2012-03-14 19:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 11:51 [PATCH/RFC 0/2] post-receive-email: declaring and consistently using one output encoding Jonathan Nieder
2012-03-08 11:57 ` [PATCH 1/2] hooks/post-receive-email: set encoding to utf-8 Jonathan Nieder
2012-03-08 11:59 ` [PATCH 2/2] post-receive-email: defend against non UTF-8 i18n.logoutputencoding setting Jonathan Nieder
2012-03-08 13:50   ` Jeff King
2012-03-08 13:52     ` Jonathan Nieder
2012-03-14 19:36   ` Alexey Shumkin
2012-03-14 19:55     ` Jonathan Nieder [this message]
2012-03-08 19:12 ` [PATCH/RFC 0/2] post-receive-email: declaring and consistently using one output encoding Junio C Hamano
2012-03-14 17:54   ` Jon Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120314195509.GA31686@burratino \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=jon@endpoint.com \
    --cc=mhagger@alum.mit.edu \
    --cc=pape@smarden.org \
    --cc=zapped@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).