From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Gerrit Pape <pape@smarden.org>,
Alexey Shumkin <zapped@mail.ru>, Johannes Sixt <j6t@kdbg.org>,
Michael Haggerty <mhagger@alum.mit.edu>,
Jon Jensen <jon@endpoint.com>
Subject: Re: [PATCH 2/2] post-receive-email: defend against non UTF-8 i18n.logoutputencoding setting
Date: Thu, 8 Mar 2012 08:50:30 -0500 [thread overview]
Message-ID: <20120308135030.GB30602@sigill.intra.peff.net> (raw)
In-Reply-To: <20120308115957.GB2750@burratino>
On Thu, Mar 08, 2012 at 05:59:57AM -0600, Jonathan Nieder wrote:
> diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
> index dc184d0b..b59e03cd 100755
> --- a/contrib/hooks/post-receive-email
> +++ b/contrib/hooks/post-receive-email
> @@ -464,7 +464,7 @@ generate_delete_branch_email()
> echo " was $oldrev"
> echo ""
> echo $LOGBEGIN
> - git show -s --pretty=oneline $oldrev
> + git diff-tree --encoding=UTF-8 -s --pretty=oneline $oldrev
> echo $LOGEND
If you are using "-s" to suppress diff output, why are you using
diff-tree? Wouldn't "rev-list -1" (or "rev-list --no-walk") work equally
well and be a little more obvious?
-Peff
next prev parent reply other threads:[~2012-03-08 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 11:51 [PATCH/RFC 0/2] post-receive-email: declaring and consistently using one output encoding Jonathan Nieder
2012-03-08 11:57 ` [PATCH 1/2] hooks/post-receive-email: set encoding to utf-8 Jonathan Nieder
2012-03-08 11:59 ` [PATCH 2/2] post-receive-email: defend against non UTF-8 i18n.logoutputencoding setting Jonathan Nieder
2012-03-08 13:50 ` Jeff King [this message]
2012-03-08 13:52 ` Jonathan Nieder
2012-03-14 19:36 ` Alexey Shumkin
2012-03-14 19:55 ` Jonathan Nieder
2012-03-08 19:12 ` [PATCH/RFC 0/2] post-receive-email: declaring and consistently using one output encoding Junio C Hamano
2012-03-14 17:54 ` Jon Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308135030.GB30602@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jon@endpoint.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=pape@smarden.org \
--cc=zapped@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).