From: Jeff King <peff@peff.net>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/3] Introduce a performance testing framework
Date: Fri, 17 Feb 2012 02:45:43 -0500 [thread overview]
Message-ID: <20120217074543.GA25213@sigill.intra.peff.net> (raw)
In-Reply-To: <5e712370fcfe32832998c085fdf6b5a7c4e7d64b.1329428159.git.trast@student.ethz.ch>
On Thu, Feb 16, 2012 at 10:41:14PM +0100, Thomas Rast wrote:
> + if test $eval_ret = 0 || test -n "$expecting_failure"
> + then
> + test_eval_ "$test_cleanup"
> + source ./test_vars || error "failed to load updated environment"
> + fi
"source" is a bash-ism (actually, it is a csh-ism as far as I know, but
perhaps it predates even that). The correct POSIX spelling is ".".
After tweaking this line, the suite seems to run fine for me with dash
as /bin/sh. Patch is below for your convenience.
-Peff
---
diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
index 07e9b09..629d7d5 100644
--- a/t/perf/perf-lib.sh
+++ b/t/perf/perf-lib.sh
@@ -135,7 +135,7 @@ exit $ret' >&3 2>&4
if test $eval_ret = 0 || test -n "$expecting_failure"
then
test_eval_ "$test_cleanup"
- source ./test_vars || error "failed to load updated environment"
+ . ./test_vars || error "failed to load updated environment"
fi
if test "$verbose" = "t" && test -n "$HARNESS_ACTIVE"; then
echo ""
next prev parent reply other threads:[~2012-02-17 11:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 21:41 [PATCH v2 0/3] Adding a performance framework Thomas Rast
2012-02-16 21:41 ` [PATCH v2 1/3] Move the user-facing test library to test-lib-functions.sh Thomas Rast
2012-02-16 22:14 ` Junio C Hamano
2012-02-17 9:00 ` Thomas Rast
2012-02-17 10:25 ` [PATCH v3 0/3] Thomas Rast
2012-02-17 10:25 ` [PATCH v3 1/3] Move the user-facing test library to test-lib-functions.sh Thomas Rast
2012-02-17 10:25 ` [PATCH v3 2/3] Introduce a performance testing framework Thomas Rast
2012-02-17 10:25 ` [PATCH v3 3/3] Add a performance test for git-grep Thomas Rast
2012-02-17 17:03 ` [PATCH v3 0/3] Junio C Hamano
2012-02-17 23:28 ` Junio C Hamano
2012-02-18 0:51 ` Jeff King
2012-02-18 7:27 ` Junio C Hamano
2012-02-18 8:52 ` Jeff King
2012-02-18 10:06 ` SIGPIPE handling (Re: [PATCH v3 0/3]) Jonathan Nieder
2012-02-18 10:10 ` Jonathan Nieder
2012-02-18 10:24 ` Jeff King
2012-02-16 21:41 ` [PATCH v2 2/3] Introduce a performance testing framework Thomas Rast
2012-02-17 7:45 ` Jeff King [this message]
2012-02-16 21:41 ` [PATCH v2 3/3] Add a performance test for git-grep Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217074543.GA25213@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).