From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Christian Couder <chriscool@tuxfamily.org>,
Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH 11/17] revert: Save data for continuing after conflict resolution
Date: Tue, 12 Jul 2011 14:37:16 -0500 [thread overview]
Message-ID: <20110712193716.GB14909@elie> (raw)
In-Reply-To: <1310396048-24925-12-git-send-email-artagnon@gmail.com>
Hi,
Ramkumar Ramachandra wrote:
> It is imperative to note that these two files alone are not enough to
> implement "--continue"; we will also need to persist the options that
> were specified on the command-line, and this is done later in the
> series.
I think you could remove the phrase "It is imperative to note that"
and this would say the same thing. :)
By the way, those two files are enough to implement --continue in some
sense, no? One implementation of --continue would forget options
passed on the first run and require the user to specify them again; it
would just be less useful. The reminder that "head" and "todo" are
not the only files in the .git/sequencer dir is useful, though; thanks
for it.
> --- a/builtin/revert.c
> +++ b/builtin/revert.c
[...]
> +static void format_todo(struct strbuf *buf, struct commit_list *todo_list,
> + struct replay_opts *opts)
> +{
> + struct commit_list *cur = NULL;
> + struct commit_message msg = { NULL, NULL, NULL, NULL, NULL };
> + const char *sha1_abbrev = NULL;
> + const char *action;
> +
> + action = (opts->action == REVERT ? "revert" : "pick");
> + for (cur = todo_list; cur; cur = cur->next) {
> + sha1_abbrev = find_unique_abbrev(cur->item->object.sha1, DEFAULT_ABBREV);
> + if (get_message(cur->item, &msg))
> + die(_("Cannot get commit message for %s"), sha1_abbrev);
> + strbuf_addf(buf, "%s %s %s\n", action, sha1_abbrev, msg.subject);
This die() seems odd in the context of a series that starts by
converting various die() calls to "return error()".
> +static struct commit *parse_insn_line(char *start, struct replay_opts *opts)
> +{
> + unsigned char commit_sha1[20];
> + char sha1_abbrev[40];
> + struct commit *commit;
> + enum replay_action action;
> + int insn_len = 0;
> + char *p;
> +
> + p = start;
> + if (!(p = strchr(p, ' ')))
> + return NULL;
Style: it is much, much clearer to write
p = strchr(start, ' ');
if (!p)
return NULL;
In the git codebase, assignments in "if" conditionals are very rare, so
code like the above sticks out.
> + insn_len = p - start;
> + if (!(p = strchr(p + 1, ' ')))
> + return NULL;
> + p += 1;
Likewise. This could say:
insn_len = p - start;
p = strchr(p + 1, ' ');
if (!p)
return NULL;
p++;
or:
p = strchrnul(start, ' ');
if (!*p)
return error("no commit name in todo file line: %s", start);
p++;
q = strchrnul(p, ' ');
if (q - p > sizeof(sha1_abbrev) - 1)
return error("commit name in todo file is too long: %s", start);
*mempcpy(sha1_abbrev, p, q - p) = '\0';
> + if (!strncmp(start, "pick", insn_len))
> + action = CHERRY_PICK;
> + else if (!strncmp(start, "revert", insn_len))
> + action = REVERT;
This code means that "p", "pi", and "pic" are accepted as
abbreviations for "pick". Maybe a comment would help to clarify
that. Are we okay with reserving these names, so "r" in a todo
file means to "revert" and not to "reword" like it does in a
rebase -i todo list?
> + /*
> + * Verify that the action matches up with the one in
> + * opts; we don't support arbitrary instructions
> + */
> + if (action != opts->action)
> + return NULL;
If I try "git cherry-pick foo..bar" and then "git revert --continue",
what error message will I get?
> +static void read_populate_todo(struct commit_list **todo_list,
> + struct replay_opts *opts)
> +{
[...]
> + for (p = buf.buf; *p; p = strchr(p, '\n') + 1) {
> + if (!(commit = parse_insn_line(p, opts)))
> + goto error;
> + new = xmalloc(sizeof(struct commit_list));
> + new->item = commit;
> + *next = new;
> + next = &new->next;
commit_list_append()?
> +static void create_seq_dir(void)
> +{
> + if (file_exists(git_path(SEQ_DIR))) {
> + if (!is_directory(git_path(SEQ_DIR)) && remove_path(git_path(SEQ_DIR)) < 0)
> + die(_("Could not remove %s"), git_path(SEQ_DIR));
> + } else if (mkdir(git_path(SEQ_DIR), 0777) < 0)
> + die_errno(_("Could not create sequencer directory '%s'."), git_path(SEQ_DIR));
> +}
As mentioned in [1], a local would make this more readable. And it's
not clear to me why one would want to delete a .git/sequencer file
that the user carefully placed there (I don't think git itself ever
writes such a thing).
> +
> +static void save_head(const char *head)
> +{
> + static struct lock_file head_lock;
> + struct strbuf buf = STRBUF_INIT;
> + int fd;
> +
> + fd = hold_lock_file_for_update(&head_lock, git_path(SEQ_HEAD_FILE), LOCK_DIE_ON_ERROR);
> + strbuf_addf(&buf, "%s\n", head);
> + if (write_in_full(fd, buf.buf, buf.len) < 0)
> + die_errno(_("Could not write to %s."), git_path(SEQ_HEAD_FILE));
> + if (commit_lock_file(&head_lock) < 0)
> + die(_("Error wrapping up %s"), git_path(SEQ_HEAD_FILE));
> +}
A local would be helpful here, too.
> +static void save_todo(struct commit_list *todo_list, struct replay_opts *opts)
> +{
> + static struct lock_file todo_lock;
> + struct strbuf buf = STRBUF_INIT;
> + int fd;
> +
> + fd = hold_lock_file_for_update(&todo_lock, git_path(SEQ_TODO_FILE), LOCK_DIE_ON_ERROR);
> + format_todo(&buf, todo_list, opts);
> + if (write_in_full(fd, buf.buf, buf.len) < 0) {
> + strbuf_release(&buf);
> + die_errno(_("Could not write to %s."), git_path(SEQ_TODO_FILE));
> + }
> + if (commit_lock_file(&todo_lock) < 0) {
> + strbuf_release(&buf);
> + die(_("Error wrapping up %s"), git_path(SEQ_TODO_FILE));
> + }
> + strbuf_release(&buf);
> +}
Likewise here. As mentioned before, git_path() clobbers errno, so the
above is likely to print a wrong error message on some systems (e.g.,
"fatal: Cannot write to .git/sequencer/todo: Success").
> +
> +static int pick_commits(struct replay_opts *opts)
> +{
> + struct commit_list *todo_list = NULL;
> + unsigned char sha1[20];
> + struct commit_list *cur;
> + int res;
>
> setenv(GIT_REFLOG_ACTION, me, 0);
> if (opts->allow_ff)
> @@ -580,14 +764,24 @@ static int pick_commits(struct replay_opts *opts)
> opts->record_origin || opts->edit));
> read_and_refresh_cache(me, opts);
>
> - prepare_revs(&revs, opts);
> + walk_revs_populate_todo(&todo_list, opts);
> + create_seq_dir();
> + if (!get_sha1("HEAD", sha1))
> + save_head(sha1_to_hex(sha1));
What happens if the .git/sequencer dir already exists (e.g., we were
in the middle of a multiple-cherry-pick)? What happens if I try to
cherry-pick onto an unborn branch, or get_sha1() fails for some other
reason?
Regards,
Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/176647/focus=176675
next prev parent reply other threads:[~2011-07-12 19:37 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 14:53 [GSoC update] Sequencer for inclusion Ramkumar Ramachandra
2011-07-11 14:53 ` [PATCH 01/17] advice: Introduce error_resolve_conflict Ramkumar Ramachandra
2011-07-11 14:53 ` [PATCH 02/17] revert: Inline add_message_to_msg function Ramkumar Ramachandra
2011-07-12 16:53 ` Jonathan Nieder
2011-07-13 6:00 ` Ramkumar Ramachandra
2011-07-13 6:42 ` Jonathan Nieder
2011-07-19 16:36 ` Ramkumar Ramachandra
2011-07-19 16:52 ` Junio C Hamano
2011-07-19 17:08 ` Ramkumar Ramachandra
2011-07-19 19:36 ` Jonathan Nieder
2011-07-20 5:32 ` Ramkumar Ramachandra
2011-07-11 14:53 ` [PATCH 03/17] revert: Don't check lone argument in get_encoding Ramkumar Ramachandra
2011-07-12 16:59 ` Jonathan Nieder
2011-07-13 6:14 ` Ramkumar Ramachandra
2011-07-13 6:30 ` Jonathan Nieder
2011-07-11 14:53 ` [PATCH 04/17] revert: Rename no_replay to record_origin Ramkumar Ramachandra
2011-07-12 17:02 ` Jonathan Nieder
2011-07-13 7:35 ` Ramkumar Ramachandra
2011-07-17 19:36 ` Jonathan Nieder
2011-07-11 14:53 ` [PATCH 05/17] revert: Propogate errors upwards from do_pick_commit Ramkumar Ramachandra
2011-07-12 17:32 ` Jonathan Nieder
2011-07-17 10:46 ` Ramkumar Ramachandra
2011-07-17 16:59 ` Jonathan Nieder
2011-07-19 10:09 ` Ramkumar Ramachandra
2011-07-11 14:53 ` [PATCH 06/17] revert: Eliminate global "commit" variable Ramkumar Ramachandra
2011-07-12 17:45 ` Jonathan Nieder
2011-07-13 6:57 ` Ramkumar Ramachandra
2011-07-13 7:10 ` Jonathan Nieder
2011-07-13 8:33 ` Ramkumar Ramachandra
2011-07-13 16:40 ` Jonathan Nieder
2011-07-11 14:53 ` [PATCH 07/17] revert: Introduce struct to keep command-line options Ramkumar Ramachandra
2011-07-12 18:05 ` Jonathan Nieder
2011-07-13 7:56 ` Ramkumar Ramachandra
2011-07-11 14:53 ` [PATCH 08/17] revert: Separate cmdline parsing from functional code Ramkumar Ramachandra
2011-07-12 18:20 ` Jonathan Nieder
2011-07-18 20:53 ` Ramkumar Ramachandra
2011-07-18 21:03 ` Jonathan Nieder
2011-07-11 14:54 ` [PATCH 09/17] revert: Don't create invalid replay_opts in parse_args Ramkumar Ramachandra
2011-07-11 20:44 ` Junio C Hamano
2011-07-12 5:57 ` Ramkumar Ramachandra
2011-07-12 18:29 ` Jonathan Nieder
2011-07-17 11:56 ` Ramkumar Ramachandra
2011-07-17 18:43 ` Jonathan Nieder
2011-07-11 14:54 ` [PATCH 10/17] sequencer: Announce sequencer state location Ramkumar Ramachandra
2011-07-12 18:56 ` Jonathan Nieder
2011-07-13 12:10 ` Sverre Rabbelier
2011-07-17 16:23 ` Ramkumar Ramachandra
2011-07-17 19:19 ` Jonathan Nieder
2011-07-18 19:44 ` Ramkumar Ramachandra
2011-07-11 14:54 ` [PATCH 11/17] revert: Save data for continuing after conflict resolution Ramkumar Ramachandra
2011-07-11 21:01 ` Junio C Hamano
2011-07-11 21:31 ` Junio C Hamano
2011-07-12 5:43 ` Ramkumar Ramachandra
2011-07-12 19:37 ` Jonathan Nieder [this message]
2011-07-17 11:48 ` Ramkumar Ramachandra
2011-07-17 18:40 ` Jonathan Nieder
2011-07-18 19:31 ` Ramkumar Ramachandra
2011-07-19 12:21 ` Jonathan Nieder
2011-07-19 12:34 ` Ramkumar Ramachandra
2011-07-11 14:54 ` [PATCH 12/17] revert: Save command-line options for continuing operation Ramkumar Ramachandra
2011-07-11 21:15 ` Junio C Hamano
2011-07-12 5:56 ` Ramkumar Ramachandra
2011-07-12 19:52 ` Jonathan Nieder
2011-07-18 20:18 ` Ramkumar Ramachandra
2011-07-11 14:54 ` [PATCH 13/17] revert: Introduce a layer of indirection over pick_commits Ramkumar Ramachandra
2011-07-12 20:03 ` Jonathan Nieder
2011-07-18 21:24 ` Ramkumar Ramachandra
2011-07-11 14:54 ` [PATCH 14/17] reset: Make hard reset remove the sequencer state Ramkumar Ramachandra
2011-07-12 20:15 ` Jonathan Nieder
2011-07-17 16:40 ` Ramkumar Ramachandra
2011-07-11 14:54 ` [PATCH 15/17] revert: Remove sequencer state when no commits are pending Ramkumar Ramachandra
2011-07-11 19:58 ` Junio C Hamano
2011-07-12 6:26 ` Ramkumar Ramachandra
2011-07-11 14:54 ` [PATCH 16/17] revert: Introduce --reset to remove sequencer state Ramkumar Ramachandra
2011-07-12 20:30 ` Jonathan Nieder
2011-07-17 17:10 ` Ramkumar Ramachandra
2011-07-17 19:25 ` Jonathan Nieder
2011-07-11 14:54 ` [PATCH 17/17] revert: Introduce --continue to continue the operation Ramkumar Ramachandra
2011-07-12 20:46 ` Jonathan Nieder
2011-07-17 16:11 ` Ramkumar Ramachandra
2011-07-17 18:32 ` Jonathan Nieder
2011-07-18 20:00 ` Ramkumar Ramachandra
2011-07-18 20:09 ` Jonathan Nieder
2011-07-11 17:17 ` [GSoC update] Sequencer for inclusion Jonathan Nieder
2011-07-11 17:57 ` Ramkumar Ramachandra
2011-07-11 20:05 ` Ramkumar Ramachandra
2011-07-11 20:11 ` Jonathan Nieder
2011-07-12 7:05 ` Ramkumar Ramachandra
2011-07-11 20:07 ` Junio C Hamano
2011-07-11 22:14 ` Jeff King
2011-07-12 6:41 ` Ramkumar Ramachandra
2011-07-12 6:47 ` Jeff King
2011-07-13 9:41 ` Ramkumar Ramachandra
2011-07-13 19:07 ` Jeff King
2011-07-18 21:37 ` [RFC PATCH] config: Introduce functions to write non-standard file Ramkumar Ramachandra
2011-07-18 23:54 ` Junio C Hamano
2011-07-19 8:52 ` Ramkumar Ramachandra
2011-07-12 5:58 ` [GSoC update] Sequencer for inclusion Jonathan Nieder
2011-07-12 6:28 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712193716.GB14909@elie \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=barkalow@iabervon.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).