From: Jonathan Nieder <jrnieder@gmail.com>
To: David Barr <david.barr@cordelta.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH/RFC] Add support for subversion dump format v3
Date: Tue, 12 Oct 2010 21:24:15 -0500 [thread overview]
Message-ID: <20101013022415.GA21670@burratino> (raw)
In-Reply-To: <1286891424-2067-1-git-send-email-david.barr@cordelta.com>
David Barr wrote:
> This series follows Jonathan Nieder's svn diff applier series.
>
> Patches 1 to 4 add the required infrastructure to fast-import.
> The primary feature is the addition of the cat-file command to
> fast-import. This allows access to objects written to the
> the current pack prior to a checkpoint and is critical to
> retrieving full-texts to drive the diff applier.
>
> Patch 5 adds the basic parsing necessary to process the v3 format.
>
> Patch 6 adds logic around decoding prop deltas.
>
> Patch 7 integrates svn-fe with svn-da to decode text deltas.
> It was primarily authored by Jonathan but inspired by Ram and
> completed by myself.
> This is probably the most sprawling of the series and likely the
> heaviest target of review.
Just wanted to say: thank you for working on this. The code
(especially on the fast-import side) needs some pruning and the result
needs tests, but in the end, we are not far from an svn-fe that can
work with "svnrdump dump" output.
In case someone is feeling generous, here is a wishlist:
- simplify the interface or add a wrapper script so callers do not
have to use mkfifo
- keep track of whether an error was encountered and exit nonzero
in that case
- rely on git to fetch old revisions (for copyfrom_rev etc) and stop
keeping track of them in svn-fe. This would simplify svn-fe a lot
and pave the way for:
- incremental imports (since no state has to persist)
And for the sake of tests:
- a simple delta producer (the remote helper would need this to
drive "svnrdump load", anyway)
- clarification (sharpening) of the notes/svndiff and
notes/dump-load-format.txt specs in Subversion
next prev parent reply other threads:[~2010-10-13 2:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 13:50 [PATCH/RFC] Add support for subversion dump format v3 David Barr
2010-10-12 13:50 ` [PATCH 1/7] Teach fast-import to print the id of each imported commit David Barr
2010-10-12 14:42 ` Sverre Rabbelier
2010-10-12 18:48 ` Jonathan Nieder
2010-10-12 18:57 ` Sverre Rabbelier
2010-10-12 19:07 ` Jonathan Nieder
2010-10-12 22:06 ` Jonathan Nieder
2010-10-12 23:05 ` Sverre Rabbelier
2010-10-12 13:50 ` [PATCH 2/7] fast-import: Let importers retrieve the objects being written David Barr
2010-10-12 22:38 ` Jonathan Nieder
2010-10-12 23:07 ` Sverre Rabbelier
2010-10-13 0:07 ` Jonathan Nieder
2010-10-13 13:10 ` Sverre Rabbelier
2010-10-12 13:50 ` [PATCH 3/7] fast-import: Allow cat command with empty path David Barr
2010-10-12 22:47 ` Jonathan Nieder
2010-10-12 13:50 ` [PATCH 4/7] fast-import: Allow cat requests at arbitrary points in stream David Barr
2010-10-12 22:50 ` Jonathan Nieder
2010-10-12 13:50 ` [PATCH 5/7] vcs-svn: extend svndump to parse version 3 format David Barr
2010-10-12 22:56 ` Jonathan Nieder
2010-10-12 13:50 ` [PATCH 6/7] vcs-svn: implement prop-delta handling David Barr
2010-10-12 22:59 ` Jonathan Nieder
2010-10-12 13:50 ` [PATCH 7/7] svn-fe: Use the --report-fd feature David Barr
2010-10-12 14:55 ` Sverre Rabbelier
2010-10-12 23:03 ` Jonathan Nieder
2010-10-12 23:11 ` Sverre Rabbelier
2010-10-12 23:36 ` Jonathan Nieder
2010-10-12 23:59 ` Jonathan Nieder
2010-10-13 2:24 ` Jonathan Nieder [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-12 13:40 [PATCH/RFC] Add support for subversion dump format v3 David Barr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013022415.GA21670@burratino \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).