From: Jonathan Nieder <jrnieder@gmail.com>
To: David Barr <david.barr@cordelta.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 1/7] Teach fast-import to print the id of each imported commit
Date: Tue, 12 Oct 2010 17:06:25 -0500 [thread overview]
Message-ID: <20101012220625.GA15587@burratino> (raw)
In-Reply-To: <1286891424-2067-2-git-send-email-david.barr@cordelta.com>
David Barr wrote:
> --- a/Documentation/git-fast-import.txt
> +++ b/Documentation/git-fast-import.txt
> @@ -92,6 +92,18 @@ OPTIONS
> --(no-)-relative-marks= with the --(import|export)-marks=
> options.
>
> +--report-fd=<fd>::
> + Print the 40-character object name for each commit to
> + the specified file descriptor before writing it to the
> + pack.
This aspect (the printing of commit ids) of the report-fd feature is
not used by the current svn-fe3 code. I'd suggest dropping it or at
least making it optional; marks work pretty well for that purpose and
it is not worth the cost or complication of making the frontend
synchronize with fast-import with every commit.
> --- a/fast-import.c
> +++ b/fast-import.c
> @@ -361,6 +361,9 @@ static uintmax_t next_mark;
> static struct strbuf new_data = STRBUF_INIT;
> static int seen_data_command;
>
> +/* Where to report commits */
> +static int report_fd = -1;
This aspect is still useful (for use by the cat command). :)
Thanks.
next prev parent reply other threads:[~2010-10-12 22:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 13:50 [PATCH/RFC] Add support for subversion dump format v3 David Barr
2010-10-12 13:50 ` [PATCH 1/7] Teach fast-import to print the id of each imported commit David Barr
2010-10-12 14:42 ` Sverre Rabbelier
2010-10-12 18:48 ` Jonathan Nieder
2010-10-12 18:57 ` Sverre Rabbelier
2010-10-12 19:07 ` Jonathan Nieder
2010-10-12 22:06 ` Jonathan Nieder [this message]
2010-10-12 23:05 ` Sverre Rabbelier
2010-10-12 13:50 ` [PATCH 2/7] fast-import: Let importers retrieve the objects being written David Barr
2010-10-12 22:38 ` Jonathan Nieder
2010-10-12 23:07 ` Sverre Rabbelier
2010-10-13 0:07 ` Jonathan Nieder
2010-10-13 13:10 ` Sverre Rabbelier
2010-10-12 13:50 ` [PATCH 3/7] fast-import: Allow cat command with empty path David Barr
2010-10-12 22:47 ` Jonathan Nieder
2010-10-12 13:50 ` [PATCH 4/7] fast-import: Allow cat requests at arbitrary points in stream David Barr
2010-10-12 22:50 ` Jonathan Nieder
2010-10-12 13:50 ` [PATCH 5/7] vcs-svn: extend svndump to parse version 3 format David Barr
2010-10-12 22:56 ` Jonathan Nieder
2010-10-12 13:50 ` [PATCH 6/7] vcs-svn: implement prop-delta handling David Barr
2010-10-12 22:59 ` Jonathan Nieder
2010-10-12 13:50 ` [PATCH 7/7] svn-fe: Use the --report-fd feature David Barr
2010-10-12 14:55 ` Sverre Rabbelier
2010-10-12 23:03 ` Jonathan Nieder
2010-10-12 23:11 ` Sverre Rabbelier
2010-10-12 23:36 ` Jonathan Nieder
2010-10-12 23:59 ` Jonathan Nieder
2010-10-13 2:24 ` [PATCH/RFC] Add support for subversion dump format v3 Jonathan Nieder
-- strict thread matches above, loose matches on Subject: below --
2010-10-12 13:40 David Barr
2010-10-12 13:40 ` [PATCH 1/7] Teach fast-import to print the id of each imported commit David Barr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012220625.GA15587@burratino \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).