From: Christian Couder <chriscool@tuxfamily.org>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH RFC] parse_object: pass on the original sha1, not the replaced one
Date: Wed, 4 Aug 2010 13:58:12 +0200 [thread overview]
Message-ID: <201008041358.13081.chriscool@tuxfamily.org> (raw)
In-Reply-To: <AANLkTikaPhV+SkzCJ+G3V39mS4FORELP34ePrPWbHFeV@mail.gmail.com>
On Tuesday 03 August 2010 08:01:32 Nguyen Thai Ngoc Duy wrote:
> On Tue, Aug 3, 2010 at 3:00 PM, Christian Couder
>
> <chriscool@tuxfamily.org> wrote:
> >> With parse_object(A), I get an object pointer whose sha1 is B.
> >>
> >> With lookup_commit(A), I get an object pointer whose sha1 is A.
> >
> > Maybe there is a bug somewhere and you should get an object pointer whose
> > sha1 is B or maybe the content of the object that was inserted in the
> > lookup table should have been the content from A and not from B.
After having another look at that, I think the content of the object in the
lookup table should be the content of A. It should be a bug if the object
returned by lookup_commit(A) does not have the content of A.
> > I will
> > try to have a deeper look at that, but it would help if you could give
> > an example of a command that triggers this behavior.
>
> The following patch add "sha1" command. These commands give different sha1:
>
> git sha1 `git rev-parse HEAD` `git rev-parse HEAD^` A
> git sha1 `git rev-parse HEAD` `git rev-parse HEAD^` B
Yes, but that does not mean that the content of the object returned by
lookup_commit(A) is not the content of A.
Or do you have an example where the content of the object returned by
lookup_commit(A) is not the content of A?
I mean that we should always be consistent by having objects with an
obj->sha1 field corresponding to the content.
So yes we have:
> With parse_object(A), I get an object pointer whose sha1 is B.
>
> With lookup_commit(A), I get an object pointer whose sha1 is A.
but it's not a problem, it's just the result from the fact that parse_object()
(completely) replace objects and lookup_commit() does not.
Best regards,
Christian.
next prev parent reply other threads:[~2010-08-04 11:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 12:36 [PATCH RFC] parse_object: pass on the original sha1, not the replaced one Nguyễn Thái Ngọc Duy
2010-08-02 7:42 ` Christian Couder
2010-08-02 9:31 ` Nguyen Thai Ngoc Duy
2010-08-03 5:00 ` Christian Couder
2010-08-03 6:01 ` Nguyen Thai Ngoc Duy
2010-08-04 11:58 ` Christian Couder [this message]
2010-08-04 12:42 ` Nguyen Thai Ngoc Duy
2010-08-04 12:57 ` Christian Couder
2010-08-04 22:07 ` Nguyen Thai Ngoc Duy
2010-08-05 11:41 ` Christian Couder
2010-08-07 4:03 ` Nguyen Thai Ngoc Duy
2010-08-13 3:59 ` Christian Couder
2010-08-13 9:02 ` Nguyen Thai Ngoc Duy
2010-08-14 2:03 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008041358.13081.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).