From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Miles Bader" <miles@gnu.org>,
"Junio C Hamano" <gitster@pobox.com>,
"David Aguilar" <davvid@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Add option to git-commit to allow empty log messages
Date: Tue, 6 Apr 2010 01:55:30 -0400 [thread overview]
Message-ID: <20100406055530.GE3901@coredump.intra.peff.net> (raw)
In-Reply-To: <20100405175822.GA32083@progeny.tock>
On Mon, Apr 05, 2010 at 12:58:22PM -0500, Jonathan Nieder wrote:
> > There's probably a lot of code out there doing `git commit -m"Yet
> > another revision"' from some cron job.
>
> FWIW, I have no strong opinion about whether to add this --allow-empty-message
> option. Maybe it would make something more convenient for someone,
> though that has to be weighed against it making it harder for everyone
> else to read the manual.
I meant to mention this in my other response: I would prefer if such an
option doesn't clutter up the usage message. --allow-empty is already
there, and probably doesn't need to be. "git commit -h 2>&1 | wc -l"
shows a whopping 39 lines, which IMHO is too many for a short usage
summary. I mean, "--no-post-rewrite", is that really one of the top-used
options?
> Hint:
>
> parent=HEAD && : or whatever &&
> tree=$(git write-tree) &&
> printf "%s\n" message |
> commit=$(git commit-tree "$tree" -p "$parent") &&
> git update-ref refs/heads/somebranch "$commit"
In addition to the bug you mention later, you also probably want to do:
parent=`git rev-parse --verify HEAD`
[...]
git update-ref \
-m 'automated commit by tool X' \
refs/heads/somebranch $commit $parent
which will give your reflog entry a more useful message, and will
protect against simultaneous updates losing history (update-ref will
make sure, while locked, that somebranch contains the $parent sha1 you
wrote as part of the commit object).
And of course it still doesn't handle parentless root commits.
So doing it right really is a bit more work than just calling "git
commit".
-Peff
next prev parent reply other threads:[~2010-04-06 5:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-03 22:06 Does Git really need a commit message to go with a commit? Ævar Arnfjörð Bjarmason
2010-04-04 1:58 ` Avery Pennarun
[not found] ` <p2kadf1fd3d1004031526r3beff4e3ldd977dfc7e9da782@mail.gmail.com>
[not found] ` <h2m51dd1af81004040415xc7381f6cp1bf81bcfd684b99d@mail.gmail.com>
2010-04-04 12:37 ` Santi Béjar
2010-04-04 14:49 ` [PATCH] Add option to git-commit to allow empty log messages Ævar Arnfjörð Bjarmason
2010-04-04 22:43 ` David Aguilar
2010-04-04 23:53 ` Ævar Arnfjörð Bjarmason
2010-04-05 2:11 ` Junio C Hamano
2010-04-05 2:15 ` Sverre Rabbelier
2010-04-05 3:57 ` Junio C Hamano
2010-04-05 14:46 ` Sverre Rabbelier
2010-04-05 5:10 ` Miles Bader
2010-04-05 5:27 ` Junio C Hamano
2010-04-05 5:51 ` Jeff King
2010-04-05 12:50 ` Ævar Arnfjörð Bjarmason
2010-04-05 17:58 ` Jonathan Nieder
2010-04-05 18:11 ` Jonathan Nieder
2010-04-06 5:55 ` Jeff King [this message]
2010-04-06 8:40 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-04-07 5:16 ` Junio C Hamano
2010-04-07 14:28 ` Ævar Arnfjörð Bjarmason
2010-04-06 8:42 ` [PATCH] " Ævar Arnfjörð Bjarmason
2010-04-07 15:09 ` [PATCH] Remove --allow-empty from the git-commit synopsis Ævar Arnfjörð Bjarmason
2010-04-07 15:29 ` Sverre Rabbelier
2010-04-07 17:28 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-04-07 17:52 ` Sverre Rabbelier
2010-04-07 18:17 ` Ævar Arnfjörð Bjarmason
2010-04-07 18:21 ` Tay Ray Chuan
2010-04-07 18:48 ` [PATCH v3] " Ævar Arnfjörð Bjarmason
2010-04-07 18:55 ` [PATCH v2] " Johannes Sixt
2010-04-07 19:00 ` Junio C Hamano
2010-04-07 19:28 ` [PATCH v4] " Ævar Arnfjörð Bjarmason
2010-04-07 19:45 ` Stephen Boyd
2010-04-07 22:25 ` [PATCH v2] " Junio C Hamano
2010-04-08 6:44 ` Jeff King
2010-04-06 5:43 ` [PATCH] Add option to git-commit to allow empty log messages Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100406055530.GE3901@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).