From: Jakub Narebski <jnareb@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Aaron Crane <git@aaroncrane.co.uk>,
Nanako Shiraishi <nanako3@lavabit.com>
Subject: Re: [PATCHv5 1/3] gitweb: refactor author name insertion
Date: Thu, 25 Jun 2009 09:39:55 +0200 [thread overview]
Message-ID: <200906250939.56361.jnareb@gmail.com> (raw)
In-Reply-To: <1245878183-2967-2-git-send-email-giuseppe.bilotta@gmail.com>
On Wed, 24 June 2009, Giuseppe Bilotta wrote:
> The refactoring allows easier customization of the output by means of
> CSS and improves extensibility on the CGI side too.
>
> Layout is preserved for all views except for 'commitdiff', which now
> uses the same format as 'commit'.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
Could you please state here, in the comments area, what are the
differences between v4 (previous) and v5 (current) version of patch,
and if there are any? It helps with patch review...
> gitweb/gitweb.css | 5 ++-
> gitweb/gitweb.perl | 79 +++++++++++++++++++++++++++++++---------------------
> 2 files changed, 51 insertions(+), 33 deletions(-)
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-06-25 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 21:16 [PATCHv5 0/3] gitweb: gravatar support Giuseppe Bilotta
2009-06-24 21:16 ` [PATCHv5 1/3] gitweb: refactor author name insertion Giuseppe Bilotta
2009-06-24 21:16 ` [PATCHv5 2/3] gitweb: gravatar support Giuseppe Bilotta
2009-06-24 21:16 ` [PATCHv5 3/3] gitweb: gravatar url cache Giuseppe Bilotta
2009-06-24 22:02 ` Junio C Hamano
2009-06-24 22:46 ` Giuseppe Bilotta
2009-06-24 23:06 ` Jacob Helwig
2009-06-24 23:31 ` Giuseppe Bilotta
2009-06-24 23:41 ` [PATCHv5bis " Giuseppe Bilotta
2009-06-25 0:01 ` [PATCHv5 " Junio C Hamano
2009-06-25 7:39 ` Jakub Narebski [this message]
2009-06-25 8:04 ` [PATCHv5 1/3] gitweb: refactor author name insertion Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906250939.56361.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@aaroncrane.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).