From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Aaron Crane <git@aaroncrane.co.uk>,
Nanako Shiraishi <nanako3@lavabit.com>,
Jacob Helwig <jacob.helwig@gmail.com>,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [PATCHv5bis 3/3] gitweb: gravatar url cache
Date: Thu, 25 Jun 2009 01:41:24 +0200 [thread overview]
Message-ID: <1245886884-5730-1-git-send-email-giuseppe.bilotta@gmail.com> (raw)
In-Reply-To: <cb7bb73a0906241631h6ad03867i796b658abc425896@mail.gmail.com>
Views which contain many occurrences of the same email address (e.g.
shortlog view) benefit from not having to recalculate the MD5 of the
email address every time.
Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
gitweb/gitweb.perl | 24 ++++++++++++++++++++++--
1 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 6e807fe..6771a9d 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3249,6 +3249,27 @@ sub git_print_header_div {
"\n</div>\n";
}
+# Rather than recomputing the url for an email multiple times, we cache it
+# after the first hit. This gives a visible benefit in views where the avatar
+# for the same email is used repeatedly (e.g. shortlog).
+# The cache is shared by all avatar engines (currently gravatar only), which
+# are free to use it as preferred. Since only one avatar engine is used for any
+# given page, there's no risk for cache conflicts.
+our %avatar_cache = ();
+
+# Compute the gravatar url for a given email, if it's not in the cache already.
+# Gravatar stores only the part of the URL before the size, since that's the
+# one computationally more expensive. This also allows reuse of the cache for
+# different sizes (for this particular engine).
+sub gravatar_url {
+ my $email = lc shift;
+ my $size = shift;
+ $avatar_cache{$email} ||=
+ "http://www.gravatar.com/avatar.php?gravatar_id=" .
+ Digest::MD5::md5_hex($email) . "&size=";
+ return $avatar_cache{$email} . $size;
+}
+
# Insert an avatar for the given $email at the given $size if the feature
# is enabled.
sub git_get_avatar {
@@ -3258,8 +3279,7 @@ sub git_get_avatar {
my $size = $avatar_size{$params{'size'}} || $avatar_size{'default'};
my $url = "";
if ($git_gravatar_enabled) {
- $url = "http://www.gravatar.com/avatar.php?gravatar_id=" .
- Digest::MD5::md5_hex(lc $email) . "&size=$size";
+ $url = gravatar_url($email, $size);
}
# Currently only gravatars are supported, but other forms such as
# picons can be added by putting an else up here and defining $url
--
1.6.3.rc1.192.gdbfcb
next prev parent reply other threads:[~2009-06-24 23:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 21:16 [PATCHv5 0/3] gitweb: gravatar support Giuseppe Bilotta
2009-06-24 21:16 ` [PATCHv5 1/3] gitweb: refactor author name insertion Giuseppe Bilotta
2009-06-24 21:16 ` [PATCHv5 2/3] gitweb: gravatar support Giuseppe Bilotta
2009-06-24 21:16 ` [PATCHv5 3/3] gitweb: gravatar url cache Giuseppe Bilotta
2009-06-24 22:02 ` Junio C Hamano
2009-06-24 22:46 ` Giuseppe Bilotta
2009-06-24 23:06 ` Jacob Helwig
2009-06-24 23:31 ` Giuseppe Bilotta
2009-06-24 23:41 ` Giuseppe Bilotta [this message]
2009-06-25 0:01 ` Junio C Hamano
2009-06-25 7:39 ` [PATCHv5 1/3] gitweb: refactor author name insertion Jakub Narebski
2009-06-25 8:04 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245886884-5730-1-git-send-email-giuseppe.bilotta@gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@aaroncrane.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.helwig@gmail.com \
--cc=jnareb@gmail.com \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).