From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Jakub Narebski <jnareb@gmail.com>,
sparse@infidigm.net, git@vger.kernel.org
Subject: Re: [Patch] Prevent cloning over http from spewing
Date: Wed, 3 Jun 2009 12:52:05 -0700 [thread overview]
Message-ID: <20090603195205.GN3355@spearce.org> (raw)
In-Reply-To: <20090603194416.GA30333@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> On Wed, Jun 03, 2009 at 12:32:06PM -0700, Shawn O. Pearce wrote:
>
> > > That's clever, and I think an "object count" would be fine (after all,
> > > that is all that git:// fetching provides). However, I'm not sure how it
> > > would work in practice. When we follow a walk to a commit in a pack, do
> > > we really want to try to pull _just_ that commit?
> >
> > No, we pull the whole pack. So the progress meter would have to
> > switch to do a content-length thing for the pack pull, then go back
> > to the object queue.
> > [...]
> > By delaying trees/blobs, I meant delaying them for loose object
> > fetch only, not pack based fetch.
>
> Ah, OK, I see. I wonder if that would make a big difference in practice.
> I expect repos to be fairly packed these days because of the I/O
> benefits (and even if people aren't doing it manually, we auto-gc
> working repos and keep pushed packs for publishing repos). So in
> practice by the time you got an accurate object count, you would be more
> or less done with the fetch (because you would have been grabbing the
> related blobs in packs as you grabbed commits and trees).
Good point, but not all repos are well packed. Think of a repo that
gets pushed to a few times a day, always under 100 objects per push,
maybe Linus'. Its a lot of loose stuff to fetch.
But, you probably are right that many of them are packed... and this
trick to try and get a more accurate progress display wouldn't be
worth the effort most of the time. Likely not worth coding.
--
Shawn.
next prev parent reply other threads:[~2009-06-03 19:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 17:42 [Patch] Prevent cloning over http from spewing sparse
2009-06-03 10:21 ` Erik Faye-Lund
2009-06-03 10:39 ` Jakub Narebski
2009-06-03 18:28 ` Junio C Hamano
2009-06-03 19:10 ` Jeff King
2009-06-03 19:15 ` Shawn O. Pearce
2009-06-03 19:24 ` Jeff King
2009-06-03 19:32 ` Shawn O. Pearce
2009-06-03 19:44 ` Jeff King
2009-06-03 19:52 ` Shawn O. Pearce [this message]
2009-06-04 12:45 ` Tay Ray Chuan
2009-06-04 16:01 ` Jeff King
2009-06-07 10:31 ` Tay Ray Chuan
2009-06-07 11:21 ` Tay Ray Chuan
2009-06-08 12:24 ` Jeff King
2009-06-10 14:03 ` Tay Ray Chuan
2009-06-10 14:07 ` Tay Ray Chuan
2009-06-11 11:11 ` Jeff King
2009-06-22 12:10 ` Tay Ray Chuan
2009-07-20 15:24 ` Tay Ray Chuan
2009-06-08 11:54 ` Jeff King
2009-06-07 11:25 ` Tay Ray Chuan
2009-06-05 0:17 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603195205.GN3355@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=peff@peff.net \
--cc=sparse@infidigm.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).