From: sparse@infidigm.net
To: git@vger.kernel.org
Subject: [Patch] Prevent cloning over http from spewing
Date: Tue, 2 Jun 2009 13:42:29 -0400 [thread overview]
Message-ID: <20090602174229.GA14455@infidigm.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 145 bytes --]
When cloning over http git spews a bunch of hashs that don't really convey much.
The attached patch disables them unless --verbose is specified.
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1192 bytes --]
commit 67be7a94c94100d24bcccf1248a26afc1dec8d05
Author: Jeff Muizelaar <jmuizelaar@mozilla.com>
Date: Tue Jun 2 13:32:41 2009 -0400
Prevent cloning over http from spewing
This propogates the verbose flag to the transport and makes
the walker verbose only if the transport is verbose.
diff --git a/builtin-clone.c b/builtin-clone.c
index 5c46496..f25d60b 100644
--- a/builtin-clone.c
+++ b/builtin-clone.c
@@ -502,8 +502,10 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
if (option_quiet)
transport->verbose = -1;
- else if (option_verbose)
+ else if (option_verbose) {
transport->progress = 1;
+ transport->verbose = 1;
+ }
if (option_upload_pack)
transport_set_option(transport, TRANS_OPT_UPLOADPACK,
diff --git a/transport.c b/transport.c
index 17891d5..3bb87f3 100644
--- a/transport.c
+++ b/transport.c
@@ -366,7 +366,7 @@ static int fetch_objs_via_walker(struct transport *transport,
walker->get_all = 1;
walker->get_tree = 1;
walker->get_history = 1;
- walker->get_verbosely = transport->verbose >= 0;
+ walker->get_verbosely = transport->verbose > 0;
walker->get_recover = 0;
for (i = 0; i < nr_objs; i++)
next reply other threads:[~2009-06-02 17:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 17:42 sparse [this message]
2009-06-03 10:21 ` [Patch] Prevent cloning over http from spewing Erik Faye-Lund
2009-06-03 10:39 ` Jakub Narebski
2009-06-03 18:28 ` Junio C Hamano
2009-06-03 19:10 ` Jeff King
2009-06-03 19:15 ` Shawn O. Pearce
2009-06-03 19:24 ` Jeff King
2009-06-03 19:32 ` Shawn O. Pearce
2009-06-03 19:44 ` Jeff King
2009-06-03 19:52 ` Shawn O. Pearce
2009-06-04 12:45 ` Tay Ray Chuan
2009-06-04 16:01 ` Jeff King
2009-06-07 10:31 ` Tay Ray Chuan
2009-06-07 11:21 ` Tay Ray Chuan
2009-06-08 12:24 ` Jeff King
2009-06-10 14:03 ` Tay Ray Chuan
2009-06-10 14:07 ` Tay Ray Chuan
2009-06-11 11:11 ` Jeff King
2009-06-22 12:10 ` Tay Ray Chuan
2009-07-20 15:24 ` Tay Ray Chuan
2009-06-08 11:54 ` Jeff King
2009-06-07 11:25 ` Tay Ray Chuan
2009-06-05 0:17 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090602174229.GA14455@infidigm.net \
--to=sparse@infidigm.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).