git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Todd Zullinger <tmz@pobox.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Thomas Spura <tomspur@fedoraproject.org>,
	git@vger.kernel.org
Subject: Re: [PATCH] completion: Add --full-diff to log/gitk options
Date: Wed, 3 Jun 2009 16:30:01 +0200	[thread overview]
Message-ID: <200906031630.09962.trast@student.ethz.ch> (raw)
In-Reply-To: <20090603122230.GZ28808@inocybe.localdomain>

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

Todd Zullinger wrote:
> I *think* __git_log_gitk_options is the proper place for it, but it's
> early in the a.m. and I'm not averse to being proved wrong.
[...]
>  # Options that go well for log and gitk (not shortlog)
>  __git_log_gitk_options="
> -	--dense --sparse --full-history
> +	--dense --sparse --full-diff --full-history

Gitk has its own setting in the Preferences called "limit diffs to
listed paths", and ignores this option, so it should go directly in
_git_log.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-06-03 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02  0:34 wrong expectation from "git log -p" Thomas Spura
2009-06-02  0:54 ` Junio C Hamano
2009-06-03 12:22   ` [PATCH] completion: Add --full-diff to log/gitk options Todd Zullinger
2009-06-03 14:30     ` Thomas Rast [this message]
2009-06-03 20:20       ` [PATCH v2] completion: Add --full-diff to log options Todd Zullinger
2009-07-05  8:35         ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906031630.09962.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    --cc=tmz@pobox.com \
    --cc=tomspur@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).