git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Todd Zullinger <tmz@pobox.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
	Thomas Spura <tomspur@fedoraproject.org>,
	git@vger.kernel.org
Subject: [PATCH] completion: Add --full-diff to log/gitk options
Date: Wed, 3 Jun 2009 08:22:30 -0400	[thread overview]
Message-ID: <20090603122230.GZ28808@inocybe.localdomain> (raw)
In-Reply-To: <7vzlcrihew.fsf@alter.siamese.dyndns.org>

Signed-off-by: Todd Zullinger <tmz@pobox.com>
---

Junio C Hamano wrote:
> Thomas Spura <tomspur@fedoraproject.org> writes:
>
>> If running "git log -p parse-options.*", the last commit is
>> df217ed6430efe444a09fffdafd39720ae3f9864
>> There are the changes this commit makes towards parse-options.*.
>>
>> I was expecting to see the full commit with all changes and not only
>> towards the 2 files - only including the two files.
>>
>> Is my expactation wrong or is this a bug?
>
> Time to run "man git-log" and look for --full-diff, perhaps?

While this patch won't do much to help people find the option, perhaps
those who learn about it will appreciate not having to type it. :)

I *think* __git_log_gitk_options is the proper place for it, but it's
early in the a.m. and I'm not averse to being proved wrong.

 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 0c8bb53..2b291ea 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1117,7 +1117,7 @@ __git_log_common_options="
 "
 # Options that go well for log and gitk (not shortlog)
 __git_log_gitk_options="
-	--dense --sparse --full-history
+	--dense --sparse --full-diff --full-history
 	--simplify-merges --simplify-by-decoration
 	--left-right
 "
-- 
1.6.3.1

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Going to hell when I die would just be redundant.

  reply	other threads:[~2009-06-03 12:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02  0:34 wrong expectation from "git log -p" Thomas Spura
2009-06-02  0:54 ` Junio C Hamano
2009-06-03 12:22   ` Todd Zullinger [this message]
2009-06-03 14:30     ` [PATCH] completion: Add --full-diff to log/gitk options Thomas Rast
2009-06-03 20:20       ` [PATCH v2] completion: Add --full-diff to log options Todd Zullinger
2009-07-05  8:35         ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090603122230.GZ28808@inocybe.localdomain \
    --to=tmz@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    --cc=tomspur@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).