* [PATCH] git-p4: Wrong sync config filename
@ 2008-04-02 8:23 Kevin Leung
2008-04-03 7:09 ` Simon Hausmann
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Leung @ 2008-04-02 8:23 UTC (permalink / raw)
To: git, simon
The filename should be p4-git-sync.cfg.db instead of p4-git-sync.cfg.
Signed-off-by: Kevin Leung <kevinlsk@gmail.com>
---
I encounter this problem after submitting the changelist to Perforce.
I was using Mac OS X 10.5 with Python 2.5.1. I am not sure if this patch will
help others.
Change 29323 submitted.
All changes applied!
Performing incremental import into refs/remotes/p4/master git branch
Depot paths: //depot/POPCAT/
Import destination: refs/remotes/p4/master
Importing revision 29323 (100%)
Do you want to rebase current HEAD from Perforce now using git-p4
rebase? [y]es/[n]o n
Traceback (most recent call last):
File "/Users/kevin/bin/git-p4", line 1828, in <module>
main()
File "/Users/kevin/bin/git-p4", line 1823, in main
if not cmd.run(args):
File "/Users/kevin/bin/git-p4", line 835, in run
os.remove(self.configFile)
OSError: [Errno 2] No such file or directory:
'/Users/kevin/cdc.git/popcat/.git/p4-git-sync.cfg'
contrib/fast-import/git-p4 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index c80a6da..623757a 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -796,7 +796,7 @@ class P4Submit(Command):
self.logSubstitutions[tokens[0]] = tokens[1]
self.check()
- self.configFile = self.gitdir + "/p4-git-sync.cfg"
+ self.configFile = self.gitdir + "/p4-git-sync.cfg.db"
self.config = shelve.open(self.configFile, writeback=True)
if self.firstTime:
--
1.5.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git-p4: Wrong sync config filename
2008-04-02 8:23 [PATCH] git-p4: Wrong sync config filename Kevin Leung
@ 2008-04-03 7:09 ` Simon Hausmann
0 siblings, 0 replies; 2+ messages in thread
From: Simon Hausmann @ 2008-04-03 7:09 UTC (permalink / raw)
To: Kevin Leung; +Cc: git
[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]
On Wednesday 02 April 2008 10:23:00 Kevin Leung wrote:
> The filename should be p4-git-sync.cfg.db instead of p4-git-sync.cfg.
>
> Signed-off-by: Kevin Leung <kevinlsk@gmail.com>
> ---
> I encounter this problem after submitting the changelist to Perforce.
>
> I was using Mac OS X 10.5 with Python 2.5.1. I am not sure if this patch
> will help others.
Thanks for the patch! Fortunately this config file is not needed anymore and I
removed its use alltogether a while ago, also as a result of running into
this problem on Mac OS X myself :). So the latest git has this resolved :)
Simon
> Change 29323 submitted.
> All changes applied!
> Performing incremental import into refs/remotes/p4/master git branch
> Depot paths: //depot/POPCAT/
> Import destination: refs/remotes/p4/master
> Importing revision 29323 (100%)
> Do you want to rebase current HEAD from Perforce now using git-p4
> rebase? [y]es/[n]o n
> Traceback (most recent call last):
> File "/Users/kevin/bin/git-p4", line 1828, in <module>
> main()
> File "/Users/kevin/bin/git-p4", line 1823, in main
> if not cmd.run(args):
> File "/Users/kevin/bin/git-p4", line 835, in run
> os.remove(self.configFile)
> OSError: [Errno 2] No such file or directory:
> '/Users/kevin/cdc.git/popcat/.git/p4-git-sync.cfg'
>
> contrib/fast-import/git-p4 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index c80a6da..623757a 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -796,7 +796,7 @@ class P4Submit(Command):
> self.logSubstitutions[tokens[0]] = tokens[1]
>
> self.check()
> - self.configFile = self.gitdir + "/p4-git-sync.cfg"
> + self.configFile = self.gitdir + "/p4-git-sync.cfg.db"
> self.config = shelve.open(self.configFile, writeback=True)
>
> if self.firstTime:
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-03 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-02 8:23 [PATCH] git-p4: Wrong sync config filename Kevin Leung
2008-04-03 7:09 ` Simon Hausmann
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).