[PATCH] git add --interactive: Autoselect single patch file

[PATCH] git add --interactive: Autoselect single patch file

[Jörg Sommer]

If there's only one file to patch, select it automaticly and don't bother
the user. In the case he didn't want do patching, he can say 'd' at the
patch prompt.
---
 git-add--interactive.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index a0a81f1..77ad6fb 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -778,7 +778,7 @@ sub patch_update_cmd {
 		print STDERR "No changes.\n";
 		return 0;
 	}
-	if ($patch_mode) {
+	if ($patch_mode or @mods == 1) {
 		@them = @mods;
 	}
 	else {
-- 
1.5.4.3

Re: [PATCH] git add --interactive: Autoselect single patch file

[Xavier Maillard]

   If there's only one file to patch, select it automaticly and don't bother
   the user. In the case he didn't want do patching, he can say 'd' at the
   patch prompt.

Like this quick-win.

Tested-by: Xavier Maillard <xma@gnu.org>

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org

[PATCH] git add --interactive: Autoselect single patch file

[Jörg Sommer]

If there's only one file to patch, select it automaticly and don't bother
the user. In the case he didn't want do patching, he can say 'd' at the
patch prompt.

Signed-off-by: Jörg Sommer <joerg@alea.gnuu.de>
---
 git-add--interactive.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index a0a81f1..77ad6fb 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -778,7 +778,7 @@ sub patch_update_cmd {
 		print STDERR "No changes.\n";
 		return 0;
 	}
-	if ($patch_mode) {
+	if ($patch_mode or @mods == 1) {
 		@them = @mods;
 	}
 	else {
-- 
1.5.4.4

Re: [PATCH] git add --interactive: Autoselect single patch file

[Johannes Schindelin]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 417 bytes --]

Hi,

On Sat, 22 Mar 2008, Jörg Sommer wrote:

> If there's only one file to patch, select it automaticly and don't 
> bother the user. In the case he didn't want do patching, he can say 'd' 
> at the patch prompt.

It also triggers when you specified a single path:

	$ git add -i that-file.c

I like it.

However, if I already specify (a) file(s), could add -i not go to the 
[p]atch option right away?

Ciao,
Dscho

Re: [PATCH] git add --interactive: Autoselect single patch file

[Wincent Colaiuta]

El 22/3/2008, a las 15:51, Johannes Schindelin escribió:

> Hi,
>
> On Sat, 22 Mar 2008, Jörg Sommer wrote:
>
>> If there's only one file to patch, select it automaticly and don't
>> bother the user. In the case he didn't want do patching, he can say  
>> 'd'
>> at the patch prompt.
>
> It also triggers when you specified a single path:
>
> 	$ git add -i that-file.c
>
> I like it.
>
> However, if I already specify (a) file(s), could add -i not go to the
> [p]atch option right away?

That's what I originally wanted and I sent a couple of patches in to  
that effect some months back. But it was argued that it is useful for  
passed-in filepatterns to limit the scope of other operations in "git  
add -i", not just the [p] subcommand, and that in turn lead to the "-- 
patch" option being implemented. I can try to dig up the message-ids  
in question if you are interested.

Still, I use the [p] subcommand so often (and almost never use any of  
the other subcommands offered by "git add -i") that I have "git patch"  
set up as an alias for "git add --patch".

Cheers,
Wincent

Re: [PATCH] git add --interactive: Autoselect single patch file

[Johannes Schindelin]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 863 bytes --]

Hi,

On Sat, 22 Mar 2008, Wincent Colaiuta wrote:

> El 22/3/2008, a las 15:51, Johannes Schindelin escribió:
> 
> >However, if I already specify (a) file(s), could add -i not go to the 
> >[p]atch option right away?
> 
> That's what I originally wanted and I sent a couple of patches in to 
> that effect some months back. But it was argued that it is useful for 
> passed-in filepatterns to limit the scope of other operations in "git 
> add -i", not just the [p] subcommand, and that in turn lead to the 
> "--patch" option being implemented. I can try to dig up the message-ids 
> in question if you are interested.
> 
> Still, I use the [p] subcommand so often (and almost never use any of 
> the other subcommands offered by "git add -i") that I have "git patch" 
> set up as an alias for "git add --patch".

Ah, I missed the --patch option.

Thanks,
Dscho