git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Karl Hasselström" <kha@treskal.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Wincent Colaiuta <win@wincent.com>, Miles Bader <miles@gnu.org>,
	Pierre Habouzit <madcoder@debian.org>,
	git@vger.kernel.org
Subject: Re: git push (mis ?)behavior
Date: Wed, 3 Oct 2007 15:14:02 +0200	[thread overview]
Message-ID: <20071003131402.GA4615@diana.vm.bytemark.co.uk> (raw)
In-Reply-To: <7v8x6kfobq.fsf@gitster.siamese.dyndns.org>

On 2007-10-03 04:08:09 -0700, Junio C Hamano wrote:

> Karl Hasselström <kha@treskal.com> writes:
>
> > So it all comes down to case (2) mistakes being much harder to fix
> > than case (1) mistakes. Therefore, we should change the default,
> > since doing so makes it safer.
>
> I am not convinced.
>
> I've seen many new people alias "rm" to "rm -i" for this (I'd say
> "false") reasoning to "default to safer", and end up training their
> fingers to say "y" without thinking.

I don't think that's a good analogy here, since no one is proposing
any kind of interactive prompt.

> Also mistakes can cut both ways. Pushing out what you did not intend
> to is what you seem to be worried about more. But not pushing out
> enough and not noticing is an equally bad mistake.

It may be an equally bad mistake, but it's _not_ equally hard to fix.
(And in my book, that means they aren't in fact equally bad.)

You're right that some users will train their fingers to always type
"git push --all" to the point where they will push everything by
mistake even in cases where that's not what they wanted. But the same
thing will happen with the current default for people who almost
always push just a single branch, and train their fingers for that.
And you just said the two mistakes were equally bad. :-)

> People also argue for "default per user". I am not really convinced
> on that point either.
>
> You, an expert, will get asked for help by somebody, walk up to his
> shell prompt, and try to help and teach him by showing you type, and
> then you suddenly notice the command does not work as you expect
> because he set the default differently (because he read that
> configuration option on some web parge). And we will be in such a
> cumbersome to diagnose situation _very_ often if we have per-user
> default on many things.

I'm generally opposed to per-user settings for that reason. Users who
insist can alias "pusha" to "push --all".

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

  parent reply	other threads:[~2007-10-03 13:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27 13:04 git push (mis ?)behavior Pierre Habouzit
2007-09-27 13:30 ` Wincent Colaiuta
2007-09-27 15:28   ` Benoit SIGOURE
2007-09-27 19:22 ` Junio C Hamano
2007-09-27 19:36   ` Pierre Habouzit
2007-09-28  6:52   ` Steffen Prohaska
2007-09-28  6:58     ` Pierre Habouzit
2007-09-28  9:26       ` Steffen Prohaska
2007-09-28  9:44         ` Junio C Hamano
2007-09-28 10:04           ` Steffen Prohaska
2007-09-28  7:07     ` Junio C Hamano
2007-09-28  9:11       ` Steffen Prohaska
2007-09-28 13:31         ` Johannes Schindelin
2007-10-09  5:05       ` Jan Hudec
2007-10-09  7:23         ` Steffen Prohaska
2007-09-28 12:38   ` Wincent Colaiuta
2007-10-03  5:10   ` Miles Bader
2007-10-03  5:39     ` Junio C Hamano
2007-10-03  6:47     ` Wincent Colaiuta
2007-10-03  8:32       ` Miles Bader
2007-10-03  7:35     ` Pierre Habouzit
2007-10-03  8:57       ` Miles Bader
2007-10-03  9:03         ` Pierre Habouzit
2007-10-03 10:25         ` Wincent Colaiuta
2007-10-03 10:49           ` Karl Hasselström
2007-10-03 11:08             ` Junio C Hamano
2007-10-03 11:22               ` Wincent Colaiuta
2007-10-03 13:14               ` Karl Hasselström [this message]
2007-10-03 15:27             ` Johannes Schindelin
2007-10-03 16:07               ` Karl Hasselström
2007-10-03 16:18                 ` Johannes Schindelin
2007-10-03 16:28                   ` Pierre Habouzit
2007-10-03 16:44                     ` Johannes Schindelin
2007-10-03 17:02                       ` Karl Hasselström
2007-10-04 14:47                         ` Steffen Prohaska
2007-10-04 15:54                           ` Wincent Colaiuta
2007-10-04 16:24                             ` Steffen Prohaska
2007-10-04 17:49                               ` Wincent Colaiuta
2007-10-03 16:26               ` Wincent Colaiuta
2007-10-03 11:10           ` Benoit SIGOURE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071003131402.GA4615@diana.vm.bytemark.co.uk \
    --to=kha@treskal.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=madcoder@debian.org \
    --cc=miles@gnu.org \
    --cc=win@wincent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).