git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Dan Libby <danda@osc.co.cr>
To: Matthias Urlichs <smurf@smurf.noris.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse
Date: Fri, 21 Sep 2007 14:21:56 -0600	[thread overview]
Message-ID: <200709211421.56587.danda@osc.co.cr> (raw)
In-Reply-To: <20070921102420.GJ11204@kiste.smurf.noris.de>

Hi,

I saw this, so I haven't run the strace command you mentioned.  No need now, 
right?

I'm no expert on these things, but I'd think that it should be replacing (or 
escaping) any characters (not just spaces) that are not allowed by 
git-check-ref-format.

For us, replacing any such characters with _ should work fine.

regards,

On Friday 21 September 2007 04:24, Matthias Urlichs wrote:
> Hi,
>
> Junio C Hamano:
> > Matthias Urlichs <smurf@smurf.noris.de> writes:
> > >> we do not like 'Cristian new code' as a tag name.
> > >
> > > Duh? That's a perfectly valid tag name.
> >
> > Is it?
> >
> > $ man git-check-ref-format
>
> Bah, stupid me. You're right, obviously.
>
> I'll replace them with underscores. :-/

-- 
Dan Libby

Open Source Consulting
San Jose, Costa Rica
http://osc.co.cr
phone: 011 506 223 7382
Fax: 011 506 223 7359

  reply	other threads:[~2007-09-21 20:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200709161857.06065.danda@osc.co.cr>
     [not found] ` <20070917070303.GI31176@kiste.smurf.noris.de>
     [not found]   ` <200709171333.48331.danda@osc.co.cr>
2007-09-18  7:47     ` [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse Matthias Urlichs
2007-09-18  8:54       ` Junio C Hamano
2007-09-18  9:29         ` Matthias Urlichs
2007-09-20 19:40           ` Dan Libby
2007-09-21  6:11             ` Matthias Urlichs
2007-09-21  6:59               ` Junio C Hamano
2007-09-21 10:24                 ` Matthias Urlichs
2007-09-21 20:21                   ` Dan Libby [this message]
2007-09-20 19:07       ` Dan Libby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709211421.56587.danda@osc.co.cr \
    --to=danda@osc.co.cr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=smurf@smurf.noris.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).