From: Dan Libby <danda@osc.co.cr>
To: Matthias Urlichs <smurf@smurf.noris.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse
Date: Thu, 20 Sep 2007 13:40:16 -0600 [thread overview]
Message-ID: <200709201340.17023.danda@osc.co.cr> (raw)
In-Reply-To: <20070918092909.GU31176@kiste.smurf.noris.de>
Hi Matthias,
So the svnimport (with your patch) chugged along for quite a while, but now
I've run into a new (related?) problem. Here's the output:
--
Merge parent branch: 57b2ce794c20e71efa9c7bd0cc71df72e01f5d39
Commit ID 37f501fd2fd0d309b4d3fdce77bac13c84646423
Writing to refs/heads/Verny
DONE: 2385 Verny 37f501fd2fd0d309b4d3fdce77bac13c84646423
Switching from 37f501fd2fd0d309b4d3fdce77bac13c84646423 to
0e1b0bb88f077b66c6cf537899ab6c0a69d5ec30 (/Cristian new code)
we do not like 'Cristian new code' as a tag name.
Cannot create tag Cristian new code: Bad file descriptor
--
This is a fatal error that stops the import.
regards,
On Tuesday 18 September 2007 03:29, Matthias Urlichs wrote:
> Some people seem to create SVN branch names with spaces
> or other shell metacharacters.
>
> Signed-Off-By: Matthias Urlichs <smurf@smurf.noris.de>
> ---
>
> Junio C Hamano:
> > > - open(H,"git-rev-parse --verify $parent |");
> > > + open(H,'-|',"git-rev-parse","--verify",$parent);
> >
> > I seem to be missing the context, but please describe what
> > problem this fixes in the commit log message. I guess some
> > people use shell metacharacters and/or SP in their branch names
> > and this is about that problem?
>
> Exactly. Sorry; it seems that the original question hasn't been posted
> to the mailing list.
>
> diff --git a/git-svnimport.perl b/git-svnimport.perl
> index d3ad5b9..aa5b3b2 100755
> --- a/git-svnimport.perl
> +++ b/git-svnimport.perl
> @@ -633,7 +633,7 @@ sub commit {
>
> my $rev;
> if($revision > $opt_s and defined $parent) {
> - open(H,"git-rev-parse --verify $parent |");
> + open(H,'-|',"git-rev-parse","--verify",$parent);
> $rev = <H>;
> close(H) or do {
> print STDERR "$revision: cannot find commit '$parent'!\n";
--
Dan Libby
Open Source Consulting
San Jose, Costa Rica
http://osc.co.cr
phone: 011 506 223 7382
Fax: 011 506 223 7359
next prev parent reply other threads:[~2007-09-20 19:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200709161857.06065.danda@osc.co.cr>
[not found] ` <20070917070303.GI31176@kiste.smurf.noris.de>
[not found] ` <200709171333.48331.danda@osc.co.cr>
2007-09-18 7:47 ` [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse Matthias Urlichs
2007-09-18 8:54 ` Junio C Hamano
2007-09-18 9:29 ` Matthias Urlichs
2007-09-20 19:40 ` Dan Libby [this message]
2007-09-21 6:11 ` Matthias Urlichs
2007-09-21 6:59 ` Junio C Hamano
2007-09-21 10:24 ` Matthias Urlichs
2007-09-21 20:21 ` Dan Libby
2007-09-20 19:07 ` Dan Libby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709201340.17023.danda@osc.co.cr \
--to=danda@osc.co.cr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).