* [PATCH] Prevent using bold text in entire gui for some fonts sometimes
@ 2007-09-18 22:33 Simon Sasburg
2007-09-20 17:01 ` Shawn O. Pearce
0 siblings, 1 reply; 2+ messages in thread
From: Simon Sasburg @ 2007-09-18 22:33 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: git
---
When I first saw git-gui on windows, I noticed it wasn't using ugly
bold fonts for it's entire gui like it was in linux. I came up with
the following patch to fix this there.
And it worked, trange thing was, even git-gui without this patch
applied was using normal fonts now. The patch didn't seem to make any
difference for me anymore. So I chalked this up to weirdness of my
system.
Yesterday though a saw that a friends git-gui was showing the same
problem with the entire gui being in bold text. And this patch fixed
it.
So its a bit weird that this patch seemed to have 'permanent' effects
for me, even after it was reverted.... but on the other hand it's
really trivial.
git-gui/git-gui.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index f789e91..28d7c21 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -1648,7 +1648,7 @@ proc apply_config {} {
set font [lindex $option 1]
if {[catch {
foreach {cn cv} $repo_config(gui.$name) {
- font configure $font $cn $cv
+ font configure $font $cn $cv -weight normal
}
} err]} {
error_popup "Invalid font specified in gui.$name:\n\n$err"
--
1.5.3.1.21.g997f2-dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Prevent using bold text in entire gui for some fonts sometimes
2007-09-18 22:33 [PATCH] Prevent using bold text in entire gui for some fonts sometimes Simon Sasburg
@ 2007-09-20 17:01 ` Shawn O. Pearce
0 siblings, 0 replies; 2+ messages in thread
From: Shawn O. Pearce @ 2007-09-20 17:01 UTC (permalink / raw)
To: Simon Sasburg; +Cc: git
Simon Sasburg <simon.sasburg@gmail.com> wrote:
> When I first saw git-gui on windows, I noticed it wasn't using ugly
> bold fonts for it's entire gui like it was in linux. I came up with
> the following patch to fix this there.
>
> And it worked, trange thing was, even git-gui without this patch
> applied was using normal fonts now. The patch didn't seem to make any
> difference for me anymore. So I chalked this up to weirdness of my
> system.
>
> Yesterday though a saw that a friends git-gui was showing the same
> problem with the entire gui being in bold text. And this patch fixed
> it.
>
> So its a bit weird that this patch seemed to have 'permanent' effects
> for me, even after it was reverted.... but on the other hand it's
> really trivial.
Yea, I can't explain that either. But this patch is really trivial
so I'm applying it anyway. Doesn't break anyone who was already
using a normal weight on their font and it should prevent others
from picking up bold everywhere. Thanks.
--
Shawn.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-20 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-18 22:33 [PATCH] Prevent using bold text in entire gui for some fonts sometimes Simon Sasburg
2007-09-20 17:01 ` Shawn O. Pearce
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).