* [PATCH] git-gui: Allow users to set commit.signoff from options.
@ 2007-07-06 14:46 Gerrit Pape
2007-07-08 21:48 ` Shawn O. Pearce
0 siblings, 1 reply; 3+ messages in thread
From: Gerrit Pape @ 2007-07-06 14:46 UTC (permalink / raw)
To: Shawn O. Pearce, git
Users may want to automatically sign-off any commit for a specific
repository. If they are mostly a git-gui user they should be able to
view/set this option from within the git-gui environment, rather than
needing to edit a raw text file on their local filesystem.
This was noticed and requested by Josh Triplett through
http://bugs.debian.org/412776
Signed-off-by: Gerrit Pape <pape@smarden.org>
---
git-gui.sh | 1 +
lib/option.tcl | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index 0096f49..5ded736 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1295,6 +1295,7 @@ set default_config(merge.summary) false
set default_config(merge.verbosity) 2
set default_config(user.name) {}
set default_config(user.email) {}
+set default_config(commit.signoff) false
set default_config(gui.pruneduringfetch) false
set default_config(gui.trustmtime) false
diff --git a/lib/option.tcl b/lib/option.tcl
index ae19a8f..28208ce 100644
--- a/lib/option.tcl
+++ b/lib/option.tcl
@@ -188,6 +188,7 @@ proc do_options {} {
{b merge.summary {Summarize Merge Commits}}
{i-1..5 merge.verbosity {Merge Verbosity}}
{b merge.diffstat {Show Diffstat After Merge}}
+ {b commit.signoff {Automatically Sign-off}}
{b gui.trustmtime {Trust File Modification Timestamps}}
{b gui.pruneduringfetch {Prune Tracking Branches During Fetch}}
--
1.5.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] git-gui: Allow users to set commit.signoff from options.
2007-07-06 14:46 [PATCH] git-gui: Allow users to set commit.signoff from options Gerrit Pape
@ 2007-07-08 21:48 ` Shawn O. Pearce
2007-07-09 7:43 ` Gerrit Pape
0 siblings, 1 reply; 3+ messages in thread
From: Shawn O. Pearce @ 2007-07-08 21:48 UTC (permalink / raw)
To: Gerrit Pape; +Cc: git
Gerrit Pape <pape@smarden.org> wrote:
> Users may want to automatically sign-off any commit for a specific
> repository. If they are mostly a git-gui user they should be able to
> view/set this option from within the git-gui environment, rather than
> needing to edit a raw text file on their local filesystem.
Sure. But your patch to git-gui actually just lets the user set
the flag, but doesn't make git-gui honor it. So the user can set
"Automatically Sign-Off" through git-gui but it will have no effect
within git-gui (git-gui doesn't use git-commit.sh, it has its own
pure-Tcl implementation).
I'm not applying this to git-gui, for the very same reason that
Junio already gave as to why he won't apply the git-commit.sh patch.
Within git-gui adding a signoff is either one mouse click (the
button on the toolbar), a single keystroke (Ctrl-S) or a menu action
(Commit->Signoff). Three easy ways to insert the signoff line.
But it still needs to be a choice from the user, every time they
make a commit.
--
Shawn.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] git-gui: Allow users to set commit.signoff from options.
2007-07-08 21:48 ` Shawn O. Pearce
@ 2007-07-09 7:43 ` Gerrit Pape
0 siblings, 0 replies; 3+ messages in thread
From: Gerrit Pape @ 2007-07-09 7:43 UTC (permalink / raw)
To: Shawn O. Pearce, git
On Sun, Jul 08, 2007 at 05:48:32PM -0400, Shawn O. Pearce wrote:
> Gerrit Pape <pape@smarden.org> wrote:
> > Users may want to automatically sign-off any commit for a specific
> > repository. If they are mostly a git-gui user they should be able to
> > view/set this option from within the git-gui environment, rather than
> > needing to edit a raw text file on their local filesystem.
>
> Sure. But your patch to git-gui actually just lets the user set
> the flag, but doesn't make git-gui honor it. So the user can set
> "Automatically Sign-Off" through git-gui but it will have no effect
> within git-gui (git-gui doesn't use git-commit.sh, it has its own
> pure-Tcl implementation).
Ups, sorry.
> I'm not applying this to git-gui, for the very same reason that
> Junio already gave as to why he won't apply the git-commit.sh patch.
>
> Within git-gui adding a signoff is either one mouse click (the
> button on the toolbar), a single keystroke (Ctrl-S) or a menu action
> (Commit->Signoff). Three easy ways to insert the signoff line.
> But it still needs to be a choice from the user, every time they
> make a commit.
Yes, thanks, Gerrit.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-09 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-06 14:46 [PATCH] git-gui: Allow users to set commit.signoff from options Gerrit Pape
2007-07-08 21:48 ` Shawn O. Pearce
2007-07-09 7:43 ` Gerrit Pape
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).