* [PATCH] Define -D__BSD_VISIBLE for FreeBSD
@ 2006-12-21 9:00 Rocco Rutte
2006-12-21 9:26 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Rocco Rutte @ 2006-12-21 9:00 UTC (permalink / raw)
To: git; +Cc: Rocco Rutte
FreeBSD (6-STABLE) "hides" many declarations (like fchmod(), IPPROTO_IPV6,
etc.) within '#ifdef __BSD_VISIBLE' blocks. Without this flag, compilation
will produce lots of warnings and will even fail to compile daemon.c
since IPPROTO_IPV6 isn't available without it.
>From looking at some include files of OpenBSD and NetBSD (via cvsweb)
they don't seem to need this flag.
Signed-off-by: Rocco Rutte <pdmef@gmx.net>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 7651104..46c49e0 100644
--- a/Makefile
+++ b/Makefile
@@ -366,7 +366,7 @@ ifeq ($(uname_O),Cygwin)
endif
ifeq ($(uname_S),FreeBSD)
NEEDS_LIBICONV = YesPlease
- BASIC_CFLAGS += -I/usr/local/include
+ BASIC_CFLAGS += -I/usr/local/include -D__BSD_VISIBLE
BASIC_LDFLAGS += -L/usr/local/lib
endif
ifeq ($(uname_S),OpenBSD)
--
1.4.4.2.g9474f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Define -D__BSD_VISIBLE for FreeBSD
2006-12-21 9:00 [PATCH] Define -D__BSD_VISIBLE for FreeBSD Rocco Rutte
@ 2006-12-21 9:26 ` Junio C Hamano
2006-12-21 10:09 ` Rocco Rutte
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2006-12-21 9:26 UTC (permalink / raw)
To: Rocco Rutte; +Cc: git
Rocco Rutte <pdmef@gmx.net> writes:
> FreeBSD (6-STABLE) "hides" many declarations (like fchmod(), IPPROTO_IPV6,
> etc.) within '#ifdef __BSD_VISIBLE' blocks. Without this flag, compilation
> will produce lots of warnings and will even fail to compile daemon.c
> since IPPROTO_IPV6 isn't available without it.
I've looked at OpenBSD header files and my impression was that
the symbol __BSD_VISIBLE was pretty much internal to the
implementation, and the programs are not expected to set it
except by defining more public feature macros, such as
_BSD_SOURCE. So I feel a bit uneasy about your approach.
We've changed this exact area quite heavily during the last
24-hours (not in Makefile but in git-compat-util.h). Do you
see the problem with the latest 'master'?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Define -D__BSD_VISIBLE for FreeBSD
2006-12-21 9:26 ` Junio C Hamano
@ 2006-12-21 10:09 ` Rocco Rutte
0 siblings, 0 replies; 3+ messages in thread
From: Rocco Rutte @ 2006-12-21 10:09 UTC (permalink / raw)
To: git
Hi,
* Junio C Hamano [06-12-21 01:26:56 -0800] wrote:
>We've changed this exact area quite heavily during the last
>24-hours (not in Makefile but in git-compat-util.h). Do you
>see the problem with the latest 'master'?
Now when looking at sys/cdefs.h, the
85023577a8f4b540aa64aa37f6f44578c0c305a3 commit seems to have broken
things. So the patch should be ignored and I'll try to come up with a
better one not using implementation-defined __-macros...
bye, Rocco
--
:wq!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-12-21 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-21 9:00 [PATCH] Define -D__BSD_VISIBLE for FreeBSD Rocco Rutte
2006-12-21 9:26 ` Junio C Hamano
2006-12-21 10:09 ` Rocco Rutte
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).